Really bothers you, huh?
These are more on the cosmetic side, but nevertheless:
- Use existing string functions (strchr() and friends) instead of manual loops
when possible
- Use short variable names for temporary local strings, such as "s" which is
used all over rpm codebase for such purposes.
- You're adding code, not ripping something out. "Disable marker on multiline
expression error messages" would be more like it (it also isn't limited to
%{expr:...})
- Multiline is typoed "mutiline" in the commit message
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/828#issuecomment-527379676
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
