pmatilai commented on this pull request.
> @@ -110,6 +110,12 @@ typedef struct _parseState {
static void exprErr(const struct _parseState *state, const char *msg,
const char *p)
{
+ const char *s = state->str;
+
+ s = strchr(s,'\n');
+ if (s && (*(s+1) != '\0'))
+ p = NULL;
+
While "s" is perfectly acceptable variable name in a case like this, a more
descriptive one would make the code that little bit more readable. Say, "nl" or
even "newline", after which the whole thing reads almost as human language.
*Almost* :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/828#pullrequestreview-285450831_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
