hroncok commented on this pull request.
> + else:
+ rpm_epoch = ''
+ while self.version[-1] == 0:
+ self.version.pop()
+ rpm_version = '.'.join(str(x) for x in self.version)
+ if self.pre:
+ rpm_suffix = '~%s' % ''.join(str(x) for x in self.pre)
+ elif self.post:
+ rpm_suffix = '^post%d' % self.post[1]
+ else:
+ rpm_suffix = ''
+ return '%s%s%s' % (rpm_epoch, rpm_version, rpm_suffix)
+
+def convert_compatible(name, operator, version_id):
+ if version_id.endswith('.*'):
+ return 'Invalid version'
What does RPM say in this case? Does it fail the build saying version cannot
have spaces? Should this script exit with 1 instead, with a meaningful error
message?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1015#pullrequestreview-346445936
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint