While many distros ship a pkg-config file for Lua downstream, the upstream source tree does not, and so we shouldn't rely on it. Turns out, CMake provides a native Lua package, so just use that.
Unfortunately, the package doesn't define any IMPORTED target, it only does the LUA_LIBRARIES and LUA_INCLUDE_DIR variables, which makes the change a tiny bit less pretty, but we can live with that for the time being. Of particular note is that this adds an "unwritten" dependency between CMake and Lua (e.g. CMake 3.18 added supports for Lua 5.4). That said, this hopefully won't have much impact on most real-life systems. Fix #include lines to use "lua.h" instead of <lua.h> as per cmake-modules(7): "... the lua location is not standardized and may exist in locations other than lua/" Fixes: #2247 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2469 -- Commit Summary -- * Don't rely on pkg-config for Lua -- File Changes -- M CMakeLists.txt (6) M build/CMakeLists.txt (4) M build/speclua.c (2) M lib/CMakeLists.txt (5) M lib/rpmscript.c (2) M rpmio/CMakeLists.txt (4) M rpmio/rpmlua.c (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2469.patch https://github.com/rpm-software-management/rpm/pull/2469.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2469 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/2...@github.com>
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
