> > Fix #include lines to use "lua.h" instead of <lua.h> as per
> > cmake-modules(7):
>
> The actual issue in the FindLua doc is cautioning against `#include
> <lua/lua.h>` because of the `lua/` _directory_ is not standardized. The
> guidance to use "lua.h" seems quite odd, as quotes imply per-project files
> rather than something from the system.
Yup, it does seem odd :smile:
> Once upon a time, the Lua interpreter sources were bundled in rpm, and for
> _that_ the quotes were the right thing to do, plus there seems to be one
> leftover from those days in rpmio/lposix.c. So I'd just fix that one case to
> use `<lua.h>` instead and leave the rest alone.
Right, and good catch, that one leftover, I'll fix up the commit as suggested.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2469#issuecomment-1498623854
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2469/c1498623...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
