@dmnks commented on this pull request.
> @@ -1,6 +1,4 @@
-# Use our top-level targets as an ordering clue to cmake: the project
-# needs to be built before we can populate anything...
-get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS)
+set(RPM_TARGETS librpm librpmio librpmbuild librpmsign)
Oh, this explains that little mystery of "why on earth doesn't this TOP_TARGETS
work for me as expected" :smile: I actually settled on that having been broken
from the start and just patched it quickly this way, with the thought of
investigating a bit more afterwards. And yes, this would've gone to a separate
commit in this PR as well :smile:
So yup, feel free to fix, I'll then just rebase. Thanks :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345326049
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2691/review/1656840...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
