@pmatilai commented on this pull request.
> @@ -1,6 +1,4 @@
-# Use our top-level targets as an ordering clue to cmake: the project
-# needs to be built before we can populate anything...
-get_property(TOP_TARGETS DIRECTORY .. PROPERTY BUILDSYSTEM_TARGETS)
+set(RPM_TARGETS librpm librpmio librpmbuild librpmsign)
It's also a good example of bad (variable) naming in the original version:
being top-level had nothing to do with it, it was the tools we were after. Had
the variable been called "TOOLPROGS" or such from the start, it probably
would've been far more obvious as to why it's not working now.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2691#discussion_r1345340162
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2691/review/1656860...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
