@pmatilai commented on this pull request.


> @@ -359,7 +360,7 @@ rpmRC rpmtxnImportPubkey(rpmtxn txn, const unsigned char 
> * pkt, size_t pktlen);
  *                     RPMRC_NOKEY on invalid keyid
  *                     RPMRC_FAIL on other failure
  */
-rpmRC rpmtxnDeletePubkey(rpmtxn txn, const char *keyid);
+rpmRC rpmtxnDeletePubkey(rpmtxn txn, rpmPubkey key);

I'm okay with adding an alternative API for this that takes a pubkey, and I'm 
okay with using this name for it even, but don't *remove* the version that 
takes a fingerprint. I explained why in the PR that added it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3374#pullrequestreview-2366419390
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3374/review/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to