@pmatilai commented on this pull request.
> @@ -359,7 +360,7 @@ rpmRC rpmtxnImportPubkey(rpmtxn txn, const unsigned char
> * pkt, size_t pktlen);
* RPMRC_NOKEY on invalid keyid
* RPMRC_FAIL on other failure
*/
-rpmRC rpmtxnDeletePubkey(rpmtxn txn, const char *keyid);
+rpmRC rpmtxnDeletePubkey(rpmtxn txn, rpmPubkey key);
Actually, scratch that.
Going forward, it is a requirement for rpmkeys (and the library part) to be
able to delete keys without being able to construct a pubkey out of it. I've
seen enough crypto related failures in the last few years that this is just
non-negotiable. But, with what we have now, we have to load it into the keyring
first anyhow. So okay for changing the argument to rpmPubkey, we'll add another
interface around the lower-level keystore later.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3374#discussion_r1799442504
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3374/review/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint
