@pmatilai commented on this pull request.
> @@ -168,10 +179,8 @@ rpmRC keystore_fs::import_key(rpmtxn txn, rpmPubkey key,
> int replace, rpmFlags f
if (!rc && replace) {
/* find and delete the old pubkey entry */
- if (delete_key(txn, fp, keyfmt) == RPMRC_NOTFOUND) {
- /* make sure an old, short keyid version gets removed */
- delete_key(txn, fp.substr(32), keyfmt);
- }
+ newname = keyfmt;
I'm not sure it helps here but it might: just a reminder that not everything
needs to be a class method. Friend functions can be useful for sharing code
that doesn't seem to fit into class hierarchy.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4005#discussion_r2431433332
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4005/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
