@pmatilai commented on this pull request.
> @@ -168,10 +179,8 @@ rpmRC keystore_fs::import_key(rpmtxn txn, rpmPubkey key,
> int replace, rpmFlags f
if (!rc && replace) {
/* find and delete the old pubkey entry */
- if (delete_key(txn, fp, keyfmt) == RPMRC_NOTFOUND) {
- /* make sure an old, short keyid version gets removed */
- delete_key(txn, fp.substr(32), keyfmt);
- }
+ newname = keyfmt;
The newname/newinstance object property does seem wrong, because it's not a
property of the keystore, it's transient data that is only relevant for a
specific situation. Which is what function parameters are for, really :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4005#discussion_r2431388689
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4005/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
