@pmatilai commented on this pull request.
> + int downgrade = 0;
+ rpmver av = rpmverParse(rpmteEVR(a));
+ rpmver bv = rpmverParse(rpmteEVR(b));
+
+ if (av && bv && rpmverCmp(av, bv) < 0)
+ downgrade = 1;
+
+ rpmverFree(av);
+ rpmverFree(bv);
+ return downgrade;
+}
+
+static char *getOp(rpmts ts, rpmte te)
+{
+ char *ret = NULL;
+ char *note = NULL;
Oh, yup. This had quite a few WIP versions indeed while pondering about the
format (before our chat on it) :laughing:
It's a silly little thing: usually the compiler would detect an unused
variable, but freeing an explicit NULL is apparently beyond them still.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4215#discussion_r3308725128
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4215/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
