http://bugzilla.rpmfusion.org/show_bug.cgi?id=96
--- Comment #11 from Chris Nolan <[EMAIL PROTECTED]> 2008-11-02 14:42:17 --- (In reply to comment #10) > Packages look quite good; some mostly minor issues: > > = common issues = > > - I think the macro > %define kmod_name wl > looks odd and is not worth the trouble, as > -- it's just use in one or two places per spec file > -- it unlikely that the kmod name will change No probs. It was useful when we kept changing the name! ;) > = broadcom-wl.spec = > > - I'd say the README (http://www.broadcom.com/docs/linux_sta/README.txt) > should > be part of the package, as it also contains a few informations for users > (maybe > the rest should get stripped) > > - Quoting from the README > > > Validate you don't have loaded (or built into the kernel) the > > Linux community provided driver for Broadcom hardware. [...] > > Is this a issue on Fedora? If yes then we should consider to blacklist the > module. But I'd like to avoid this, as it makes adding this driver to live-cds > harder (as we don't want to blacklist b43 in general) Yes, this is an issue on Fedora. The driver conflicts with bcm43xx, ssb, b43 and ndiswrapper kernel modules. I use the following when installing manually: echo "blacklist bcm43xx" >> /etc/modprobe.d/blacklist echo "blacklist ssb" >> /etc/modprobe.d/blacklist echo "blacklist b43" >> /etc/modprobe.d/blacklist echo "blacklist ndiswrapper" >> /etc/modprobe.d/blacklist and also: echo "alias wlan0 wl" >> /etc/modprobe.conf I guess for the sake of upgrading/removing the RPM that would be better done with a new single modprobe.d file "/etc/modprobe.d/broadcom-wl" perhaps? As for the README.txt - should we use a stripped down version of the official file or should we alter it to be more specific to Fedora/RPM installation? > = wl-kmod.spec = > > - Please remove the > #define buildforkernels current > #define buildforkernels akmod > stuff > Cool. Thanks Thorsten. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
