https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098
--- Comment #15 from Alec Leamas <[email protected]> 2012-02-21 11:32:11 CET --- More complete review. Hope this is not bad news :) --a [OK] Package meets naming guidelines [OK] Spec file matches base package name. [OK] Spec has consistent macro usage. [E ] Meets Packaging Guidelines. Bundled libraries, source URL not properly commented. [OK] License field OK [E ] License field in spec matches source Some files are BSD [OK] License file included in package [OK] Spec in American English [OK] Spec is legible. [? ] Sources match upstream md5sum: Can't build tarball from upstream, missing input in comment. md5sum of tarball in srpm: 0b5f8cde0295d0742547010472854eaa [? ] Package needs ExcludeArch Possibly just x86 due to SSE2 requirement. [E ] BuildRequires correct Koji builds fails on F16-F17 due to BR. [OK] Spec handles locales/find_lang [NA] Package is relocatable and has a reason to be. [OK] Package has no %defattr or permissions. [OK] Package has a no %clean section. [OK] Package has no buildroot [OK] Package is code or permissible content. [NA] Doc subpackage needed/used. [OK] Packages %doc files don't affect runtime. [OK] Package is a GUI app and has a .desktop file [OK] Package compiles and builds on at least one arch. f15/i386 [OK] Package has no duplicate files in %files. [OK] Package doesn't own any directories other packages own. [OK] Package owns all the directories it creates. [OK] No rpmlint output. Output below. It can be ignored besides the Source URL warning, iff upstream has a report about the bad FSF addresses. [OK] final provides and requires are sane: See below SHOULD Items: [E ] Should build in mock. f16,f17 fails in koji. [? ] Should build on all supported archs Not tested [OK] Should function as described. Starts, menus seems to work. Not much of a test. [OK] Should have sane scriptlets. [NA] Should have subpackages require base package with fully versioned depend. [OK] Should have dist tag [OK] Should package latest version [NA] check for outstanding bugs on package. (For core merge reviews) Issues: 1. Bundles bochs/disasm in Externals http://bochs.sourceforge.net/cgi-bin/lxr/source/disasm. 2. Bundles clrun, from clunix in Externals http://www.cmap.polytechnique.fr/~sylvain/clunix. 3. Source/Core/Core/Src/IPC_HLE contains the kernel headers hci.h and l2cap.h, which seems like a bad bundling. 4. From README, dolphin-emu needs SSE2 support. Does this rule out non-x86 architectures, which needs to be excluded? 5. Source URL is not completely commented on how to generate tarball. Why don't you just use upstream tarball as-is, add the add-on files as SourceX: and removes Externals/misc in %prep? This is more transparent and makes source verification simple. 6. A number of files have BSD licenses. Shouldn't these be part of License tag like in "GPLv2 and BSD" or similar? 7. Koji build fails on F16/F17, bad BR. 8. No review remark as such, but the install icons part is a little messy, could possibly be rewritten like: for size in 16 32 48 128 256; do dim="${size}x${size}" install -p -D -m 0644 %{name}$size.png \ %{buildroot}%{_datadir}/icons/hicolor/$dim/apps/%{name}.png done Similarly, the %files section icons could be written: %{_datadir}/icons/hicolor/*/apps/%{name}.png However, this boils down to personal preferences. Rpmlint: [leamas] $ rpmlint ~/rpmbuild/RPMS/i686/dolphin-emu-3.0-4.fc15.i686.rpm ~/rpmbuild/RPMS/i686/dolphin-emu-debuginfo-3.0-4.fc15.i686.rpm dolphin-emu ~/rpmbuild/SPECS/dolphin-emu.spec | uniq dolphin-emu.i686: W: spelling-error Summary(en_US) Gamecube -> Game cube, Game-cube, Gamecock dolphin-emu.i686: E: zero-length /usr/share/dolphin-emu/user/GameConfig/WBEEJV.ini dolphin-emu.i686: W: no-manual-page-for-binary dolphin-emu ~/rpmbuild/SPECS/dolphin-emu.spec: W: invalid-url Source0: dolphin-emu-3.0.tar.gz dolphin-emu-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/dolphin-emu-3.0/Source/Core/Core/Src/DSP/DSPHWInterface.cpp [repeated 11 times] 3 packages and 1 specfiles checked; 13 errors, 5 warnings Final Requires/Provides: dolphin-emu-3.0-4.fc15.i686.rpm dolphin-emu = 3.0-4.fc15 dolphin-emu(x86-32) = 3.0-4.fc15 = /bin/sh libCg.so libCgGL.so libGL.so.1 libGLEW.so.1.5 libGLU.so.1 libICE.so.6 libSDL-1.2.so.0 libSM.so.6 libSOIL.so.1 libX11.so.6 libXext.so.6 libXrandr.so.2 libao.so.4 libasound.so.2 libasound.so.2(ALSA_0.9) libasound.so.2(ALSA_0.9.0rc4) libatk-1.0.so.0 libavcodec.so.52 libavcodec.so.52(LIBAVCODEC_52) libavformat.so.52 libavformat.so.52(LIBAVFORMAT_52) libavutil.so.50 libavutil.so.50(LIBAVUTIL_50) libbluetooth.so.3 libcairo.so.2 libdl.so.2 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgomp.so.1 libgomp.so.1(GOMP_1.0) libgomp.so.1(OMP_1.0) libgtk-x11-2.0.so.0 liblzo2.so.2 libopenal.so.1 libpango-1.0.so.0 libportaudio.so.2 libpulse.so.0 libpulse.so.0(PULSE_0) libsfml-network.so.1.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libswscale.so.0 libswscale.so.0(LIBSWSCALE_0) libwx_baseu-2.8.so.0 libwx_baseu-2.8.so.0(WXU_2.8) libwx_gtk2u_adv-2.8.so.0 libwx_gtk2u_adv-2.8.so.0(WXU_2.8) libwx_gtk2u_aui-2.8.so.0 libwx_gtk2u_aui-2.8.so.0(WXU_2.8) libwx_gtk2u_aui-2.8.so.0(WXU_2.8.9) libwx_gtk2u_core-2.8.so.0 libwx_gtk2u_core-2.8.so.0(WXU_2.8) libz.so.1 dolphin-emu-debuginfo-3.0-4.fc15.i686.rpm dolphin-emu-debuginfo = 3.0-4.fc15 dolphin-emu-debuginfo(x86-32) = 3.0-4.fc15 = -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.
