https://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
Göran Uddeborg <goe...@uddeborg.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #33 from Göran Uddeborg <goe...@uddeborg.se> 2012-10-30 19:33:14 CET --- > > Why not just do "%doc %SOURCE2 > > This doesn't work. I had a memory of doing that. But you are right, it doesn't work. And it is documented on http://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch09s05s03.html so I guess I'm confusing it with something else I did. Sorry for that confusion. > I did it that way because somewhere I got the impression that %build should do > nothing for noarch packages. Uh, that sounds odd. Why would that be? As counter examples, all Java packages I have seen do the compilation in %build. And the https://fedoraproject.org/wiki/Packaging:Java has several examples of using %build. Many of those packages are noarch. You had a discussion earlier in this bugzilla about having an explicit %build section even if it is empty. But I don't see anything here that says it HAS to be empty. So while I still don't insist on you moving the image formatting, I don't think there is any rule against it. > winetricks brings in enough GNOME stuff to ensure that directory exists. Ah, I see, it is pulled in via zenity which requires gtk3 which requires hicolor-icon-theme! Yes, then it is ok. So, the only remaining question is about where to run rsvg-convert, and I already said I don't think this is a blocker if you don't agree with me. This package is *ACCEPTED*. PS. If you would like to add Swedish versions of the documentation to your package (second "should" point), here it is: Summary(sv): Ett enkelt sätt att undvika problem med Wine %description -l sv Winetricks är ett enkelt sätt att undvika problem med Wine. Det har en meny över spel/program som stödjs och för vilka det installerar sätt att gå runt problem automatiskt. Det låter dig också installera saknade DLL:er eller justera diverse inställningar i Wine individuellt. Det kan användas via ett grafiskt gränssnitt eller från kommandoraden, vilket du föredrar. Kommandoradsläget är speciellt användbart som en byggsten i elegantare framändar till Wine och i automatiserad regressionstestning. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.