https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554
--- Comment #6 from MartinKG <[email protected]> 2015-03-01 18:03:30 CET --- (In reply to comment #3) > Program itself seems to be working correctly. > > * License > - Well, please never modify license text downstream, even > if rpmlint complains for it. > License modification must be done only on upstream. reported upstream > > * BuildRequires: > - For pkgconfig based BR (i.e. "PKG_CHECK_MODULES" in configure.ac) > it is better to use pkgconfig vitual BR, like > BuildRequires: pkgconfig(flac) (not a blocker) Done > > * License tag > - (not a blocker) License tag can simply be GPLv2+ > (This is effectively one single binary, and writing multiple > licenses where GPLv2+ is predominant actually does not make > sense) > Done > * License file > - Use %license for license text: > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text > Done > * %defattr > - %defattr can be removed (current rpmbuild does not need this > any longer) > Done > * rpmfusion category > - Well, I think this is "free" category for rpmfusion, not "nonfree" > > This package needs to link the following nonfree > > libraries, so this package is nonfree. > My recognition is that they are actually "free" (patent issue > or so does not make it "nonfree" category), would you check > this? (Also check MOCK.log attached) > > * incorrect-fsf-address rpmlint > - Please ping upsteam later (check rpmlint result for -debuginfo rpm) > (not a blocker) > report this later > Well, please check above. I don't see strict blocker for this package. Done new SPE/SRPM file: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/aqualung.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/aqualung-0.9-0.7.svn1309.fc21.src.rpm %changelog * Sun Mar 01 2015 Martin Gansser <[email protected]> - 0.9-0.7.svn1309 - added link to upstream patch %%{name}-fsf-fix.patch - corrected lincese tag - Mark license files as %%license where available - dropped %%defattr does not need any longer - dropped macro %%{buildroot} - take ownership of unowned directory %%{_datadir}/%%{name}/ - added pkgconfig based BR -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
