https://bugzilla.rpmfusion.org/show_bug.cgi?id=5015
--- Comment #5 from Antonio Trande <anto.tra...@gmail.com> ---
(In reply to Nicolas Chauvet from comment #4)
> - Please use one BR per line:
>
> - Drop uneeded libglvnd-devel,mesa-libwayland-egl you don't want that as a
> application.
>
> - Please use libGL-devel instead of mesa (that might move to
> libglvnd-libGL-devel or else in the future, so using libGL-devel is the way
> forward).
> Same for libGLES-devel and libEGL-devel
>
> - Requires: hicolor-icon-theme, is this still needed nowadays ?
Yes, unless it is installed by default.
>
> - You fix on armv7 looks a bit strong. Specially:
> "-mtune=cortex-a15.cortex-a7 -mcpu=cortex-a15 -mfpu=neon-vfpv4"
> Isn't using -mfpu=neon enough ? Also it overrides fedora march flags because
> fedora uses: -march=armv7-a instead of -march=arm (we don't care about
> armv6hl).
>
> So to me theses flags should be acceptable
> "-mfpu=neon -fomit-frame-pointer -ftree-vectorize -mvectorize-with-neon-quad
> -ffast-math -DARM_NEON"
> But it will discard non-neon armv7 hardware (such a tegra2 Trimslice or
> others). But I guess these devices might not be capable to handle the
> emulator well.
> If it's the case, best is to verify that the device has the needed
> capability before running the binary.
Those flags come from upstream fix. I'm using yours now.
>
> - Why vulkan is kept disabled in cmake ?
Enabled. An old build test.
> - Why GLES2 is disabled in cmake but added in configure flags and BR ?
> FYI, I'm splitted with GLES2, fedora seems to prefer to rely on "desktop
> GL", but many drivers might not expose full desktop opengl 2.0 support, so
> here a gles2 rendering path might looks more appropriate.
> This is not only the case on arm where some FLOSS drivers are still limited,
> but also on x86 (Intel Pinetrail was downgraded to only advertise OpenGL 1.4
> because of too much missing capabilities but still advertise GLES 2.0).
GLES support is not currently compiled fine
>
> - Why a special case here ?
> %if 0%{?rhel}
> -DWAYLAND_EGL_LIBRARIES:FILEPATH=%{_libdir}/libwayland-egl.so.1 \
> %endif
>
> Please remind that Wayland on RHEL is a technical preview. I don't think
> much people
I've corrected BR packages, that line is useless now.
>
> - Using git snapshot is documented here:
> https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services
> I don't understand why you would need to use theses sub-modules. To me,
> there is a need to unbundle them. Unless the ones available in fedora
> aren't new enough ?
CMake wants them, but they are not included in the source code of PPSSPP.
Commit 9a610c8a012e73b7d2c6677f48d24f3e185e61c7 coincides with the release
1.6.3.
SPEC file: https://sagitter.fedorapeople.org/ppsspp/ppsspp.spec
SRPM file: https://sagitter.fedorapeople.org/ppsspp/ppsspp-1.6.3-3.fc28.src.rpm
el7 scratch build: http://koji.rpmfusion.org/koji/taskinfo?taskID=257413
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
