https://bugzilla.rpmfusion.org/show_bug.cgi?id=5015
Nicolas Chauvet <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|rpmfusion-package-review@rp |[email protected]
|mfusion.org |
Flags| |fedora-review?
--- Comment #9 from Nicolas Chauvet <[email protected]> ---
(In reply to Antonio Trande from comment #8)
> Ready to go on.
>
> SPEC file: https://sagitter.fedorapeople.org/ppsspp/ppsspp.spec
> SRPM file:
> https://sagitter.fedorapeople.org/ppsspp/ppsspp-1.6.3-4.20180912git6d0ed4a.
> fc28.src.rpm
I've a cosmetic change I would like to suggest:
Please consider adding two lines of spaces between RPM sections
(%prep,%build,%install,%files,%changelog) and only one within a section.
This will improve readability for your spec files.
I'm still not sure about having a %{rhel} condition.
If using libEGL-devel doesn't work, please use mesa-libEGL-devel everywhere
But I might investigate this. (same for GLES)
Please drop epel-rpm-macros mesa-libwayland-egl-devel libglvnd-egl
Theses should not be used directly by the package (but either bring by the
infra or internal dependencies of others dependencies).
Please avoid to condition the arm patch to the architecture.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
