https://bugzilla.rpmfusion.org/show_bug.cgi?id=5030
Richard <hobbes1...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugzilla.rpmfusion.
| |org/show_bug.cgi?id=4928
Blocks| |2
--- Comment #1 from Richard <hobbes1...@gmail.com> ---
This is based on Nicolas's package and has been updated to 390.87.
(In reply to Robert-André Mauchin from comment #1)
> # install AppData and add modalias provides
> mkdir -p %{buildroot}%{_datadir}/appdata/
> install -pm 0644 %{SOURCE12} %{buildroot}%{_datadir}/appdata/
>
> /usr/share/appdata is deprecated in favour of /usr/share/metainfo
>
> See:
> https://www.freedesktop.org/software/appstream/docs/sect-Metadata-
> Application.html
> and: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html
Fixed.
> install -p -m 0644 %{SOURCE21} %{buildroot}%{_unitdir}
>
> Shouldn't you run the systemd scriptlets for this service file?
>
> %post
> %systemd_post nvidia-fallback.service
>
> %preun
> %systemd_preun nvidia-fallback.service
>
> %postun
> %systemd_postun_with_restart nvidia-fallback.service
See: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4928#c3
> - xorg-x11-drv-nvidia-390xx.src:16: W: mixed-use-of-spaces-and-tabs
> (spaces: line 1, tab: line 16)
>
> Line 16, 19, 33, 34: replace the tabs with spaces
>
> - Would be nice to escape all the macros in comment
Fixed in spec (and link) but I did not upload a new srpm for it.
> Package Review
> ==============
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
>
> Issues:
> =======
> - Package installs properly.
> Note: Installation errors (see attachment)
> See: https://fedoraproject.org/wiki/Packaging:Guidelines
> - systemd_post is invoked in %post, systemd_preun in %preun, and
> systemd_postun in %postun for Systemd service files.
> Note: Systemd service file(s) in xorg-x11-drv-nvidia-390xx
> See: https://fedoraproject.org/wiki/Packaging:Scriptlets#Scriptlets
> - Development (unversioned) .so files in -devel subpackage, if present.
> Note: Unversioned so-files directly in %_libdir.
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
> - Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 1699840 bytes in 53 files.
> See:
> http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
>
>
> ===== MUST items =====
>
> C/C++:
> [-]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
>
> Generic:
> [-]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [x]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "GPL", "MIT/X11 (BSD like)", "SGI Free Software License B
> (v1.1)", "Unknown or generated", "BSD (3 clause)". 257 files have
> unknown license. Detailed output of licensecheck in
> /home/bob/packaging/review/xorg-x11-drv-nvidia-390xx/review-xorg-x11
> -drv-nvidia-390xx/licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [-]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/lib/udev,
> /usr/share/glvnd/egl_vendor.d, /usr/share/glvnd, /usr/lib/modprobe.d,
> /usr/lib/udev/rules.d, /usr/lib/dracut/dracut.conf.d, /usr/lib/dracut
> [x]: Package does not own files or directories owned by other packages.
> Note: Dirs in package are owned also by: /etc/nvidia(xorg-x11-drv-
> nvidia), /usr/lib/nvidia(xorg-x11-drv-nvidia-libs, xorg-x11-drv-
> nvidia), /usr/include/nvidia(xorg-x11-drv-nvidia-devel),
> /usr/include/nvidia/GL(xorg-x11-drv-nvidia-devel),
> /usr/share/nvidia(xorg-x11-drv-nvidia)
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [-]: Sources contain only permissible code or content.
> [x]: %config files are marked noreplace or the reason is justified.
> Note: No (noreplace) in %config /etc/OpenCL/vendors/nvidia.icd
> [-]: Package contains desktop file if it is a GUI application.
> [x]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
> names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [x]: Package contains systemd file(s) if in need.
> [-]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Rpmlint is run on all rpms the build produces.
> Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: No %config files under /usr.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
> provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
>
> ===== SHOULD items =====
>
> Generic:
> [-]: If the source package does not include license text(s) as a separate
> file from upstream, the packager SHOULD query upstream to include it.
> [x]: Final provides and requires are sane (see attachments).
> [x]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xorg-x11
> -drv-nvidia-390xx-devel , xorg-x11-drv-nvidia-390xx-cuda , xorg-x11
> -drv-nvidia-390xx-cuda-libs , xorg-x11-drv-nvidia-390xx-kmodsrc ,
> xorg-x11-drv-nvidia-390xx-libs
> [?]: Package functions as described.
Working on my system right now.
> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [-]: Description and summary sections in the package spec file contains
> translations for supported Non-English languages, if available.
> [-]: %check is present and all tests pass.
> [x]: Packages should try to preserve timestamps of original installed
> files.
> [x]: Reviewer should test that the package builds in mock.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
> $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
> [x]: SourceX is a working URL.
> [x]: Package should compile and build into binary rpms on all supported
> architectures.
> [x]: Spec use %global instead of %define unless justified.
>
> ===== EXTRA items =====
>
> Generic:
> [-]: Rpmlint is run on all installed packages.
> Note: Mock build failed
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
> [-]: Large data in /usr/share should live in a noarch subpackage if package
> is arched.
> Note: Arch-ed rpms have a total of 10291200 bytes in /usr/share
> See:
>
> http://fedoraproject.org/wiki/Packaging:
> ReviewGuidelines#Package_Review_Guidelines
> [x]: Spec file according to URL is the same as in SRPM.
>
>
>
> Rpmlint
> -------
> Checking: xorg-x11-drv-nvidia-390xx-390.67-1.fc29.x86_64.rpm
> xorg-x11-drv-nvidia-390xx-devel-390.67-1.fc29.x86_64.rpm
> xorg-x11-drv-nvidia-390xx-cuda-390.67-1.fc29.x86_64.rpm
> xorg-x11-drv-nvidia-390xx-cuda-libs-390.67-1.fc29.x86_64.rpm
> xorg-x11-drv-nvidia-390xx-kmodsrc-390.67-1.fc29.x86_64.rpm
> xorg-x11-drv-nvidia-390xx-libs-390.67-1.fc29.x86_64.rpm
> xorg-x11-drv-nvidia-390xx-390.67-1.fc29.src.rpm
> xorg-x11-drv-nvidia-390xx.x86_64: W: spelling-error %description -l en_US
> chipsets -> chip sets, chip-sets, Chiclets
> xorg-x11-drv-nvidia-390xx.x86_64: W: obsolete-not-provided nvidia-390xx-kmod
> xorg-x11-drv-nvidia-390xx.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/nvidia-390xx/xorg/libglx.so
> xorg-x11-drv-nvidia-390xx.x86_64: W: no-manual-page-for-binary
> nvidia-bug-report.sh
> xorg-x11-drv-nvidia-390xx.x86_64: W: dangerous-command-in-%pre rm
> xorg-x11-drv-nvidia-390xx.x86_64: W: dangerous-command-in-%preun mv
> xorg-x11-drv-nvidia-390xx-devel.x86_64: E: description-line-too-long C This
> package provides the development files of the xorg-x11-drv-nvidia-390xx
> package,
> xorg-x11-drv-nvidia-390xx-devel.x86_64: W: no-documentation
> xorg-x11-drv-nvidia-390xx-cuda.x86_64: W: only-non-binary-in-usr-lib
> xorg-x11-drv-nvidia-390xx-cuda.x86_64: W: conffile-without-noreplace-flag
> /etc/OpenCL/vendors/nvidia.icd
> xorg-x11-drv-nvidia-390xx-cuda.x86_64: W: no-manual-page-for-binary
> nvidia-cuda-mps-server
> xorg-x11-drv-nvidia-390xx-cuda.x86_64: W: no-manual-page-for-binary
> nvidia-debugdump
> xorg-x11-drv-nvidia-390xx-cuda-libs.x86_64: W: no-documentation
> xorg-x11-drv-nvidia-390xx-cuda-libs.x86_64: W:
> devel-file-in-non-devel-package /usr/lib64/libcuda.so
> xorg-x11-drv-nvidia-390xx-kmodsrc.x86_64: W: summary-not-capitalized C
> xorg-x11-drv-nvidia-390xx kernel module source code
> xorg-x11-drv-nvidia-390xx-kmodsrc.x86_64: W: spelling-error %description -l
> en_US kmod -> mod, k mod, mood
> xorg-x11-drv-nvidia-390xx-kmodsrc.x86_64: E: description-line-too-long C
> Source tree used for building kernel module packages
> (xorg-x11-drv-nvidia-390xx-kmod)
> xorg-x11-drv-nvidia-390xx-kmodsrc.x86_64: W: no-documentation
> xorg-x11-drv-nvidia-390xx-libs.x86_64: W: shared-lib-calls-exit
> /usr/lib64/libGLX_nvidia.so.390.67 exit@GLIBC_2.2.5
> xorg-x11-drv-nvidia-390xx-libs.x86_64: W: no-documentation
> xorg-x11-drv-nvidia-390xx.src: W: spelling-error %description -l en_US
> chipsets -> chip sets, chip-sets, Chiclets
> xorg-x11-drv-nvidia-390xx.src: W: strange-permission parse-readme.py 755
> xorg-x11-drv-nvidia-390xx.src:7: E: hardcoded-library-path in
> %{_prefix}/lib/nvidia
> xorg-x11-drv-nvidia-390xx.src:19: E: hardcoded-library-path in
> %{_prefix}/lib/dracut/dracut.conf.d
> xorg-x11-drv-nvidia-390xx.src:20: E: hardcoded-library-path in
> %{_prefix}/lib/modprobe.d/
> xorg-x11-drv-nvidia-390xx.src:86: W: macro-in-comment %{version}
> xorg-x11-drv-nvidia-390xx.src:88: W: macro-in-comment %{version}
> xorg-x11-drv-nvidia-390xx.src:90: W: macro-in-comment %{version}
> xorg-x11-drv-nvidia-390xx.src:147: W: macro-in-comment %{version}
> xorg-x11-drv-nvidia-390xx.src:153: W: macro-in-comment %{version}
> xorg-x11-drv-nvidia-390xx.src:434: W: deprecated-grep ['fgrep']
> xorg-x11-drv-nvidia-390xx.src:16: W: mixed-use-of-spaces-and-tabs (spaces:
> line 1, tab: line 16)
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error warning: Macro expanded in
> comment on line 86: %{?_isa} = %{version}
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error warning: Macro expanded in
> comment on line 87: %{?fedora}
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error warning: Macro expanded in
> comment on line 88: %{?_isa} = %{version}
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error warning: Macro expanded in
> comment on line 90: %{?_isa} = %{version}
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error warning: Macro expanded in
> comment on line 147: %{?_isa} = %{version}
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error
> xorg-x11-drv-nvidia-390xx.src: E: specfile-error warning: Macro expanded in
> comment on line 153: %{?_isa} = %{version}
> 7 packages and 0 specfiles checked; 16 errors, 27 warnings.
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
