https://bugzilla.rpmfusion.org/show_bug.cgi?id=5103

--- Comment #3 from Klaas Demter <klaasdemter+rpmfus...@gmail.com> ---
(In reply to Nicolas Chauvet from comment #2)
> Also do you have a fedora/rpmfusion FAS account
yes, fedora FAS username is klaas

(In reply to Nicolas Chauvet from comment #1)
> Thx for the package submission.
> 
> Try to be more verbose about this review, also a presentation on
> rpmfusion-devel mailing list would be welcomed.
> 
> Also have a look on the "required" formalism for review request.
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=5366
I'll have a look at that
> 
> Few comments.
> - Is this package can build in mock ?
I only build it with rpmbuild locally
> - Is there a missing build requires (libarchive-devel ?)
that could very well be the case :)
> - Please do not redefine camke make (you can audit what are used by default
> using rpm -E %cmake )
I am not sure what you mean here, it's been a whlie since I made that spec file
but I think that was the only way I could get it to build properly :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Reply via email to