https://bugzilla.rpmfusion.org/show_bug.cgi?id=5103
--- Comment #7 from FeRD (Frank Dana) <ferd...@gmail.com> ---
Couple of other notes about the spec file:
Source0: https://github.com/xbmc/%{aname}/archive/%{version}-Leia.tar.gz
#https://github.com/xbmc/vfs.libarchive/archive/1.0.4-Leia.tar.gz
That commented URL line is unnecessary and could potentially cause confusion,
especially in the future when newer versions are released and built. (I assume
it was just used as a reference template for building the Source0 line — which
works fine, as a successful spectool run demonstrates.)
ExcludeArch: %{power64} ppc64le
The "ppc64le" is redundant, %power64 already includes ppc64le.
"Excludearch: %{power64}" would also match the current kodi.spec.
%cmake -DADDONS_TO_BUILD=vfs.libarchive -DADDON_SRC_PREFIX=.
-DCMAKE_BUILD_TYPE=Release
It would be better to use -DCMAKE_BUILD_TYPE=RelWithDebInfo, to facilitate
extraction of debugging symbols and creation of a -debuginfo package. (Again,
this would match what's used in the current kodi.spec.)
%description
%{summary}.
Meh. I know that's not _technically_ prohibited. (It's a favorite of the wine
packagers, for one, in (not-)describing many subpackages.) I personally find it
kind of lazy, though.
And in this specific case, I feel like there's plenty more that COULD be said
to describe the package. What the heck is a "VFS libarchive addon"? Why would
someone want to install it into Kodi? What extra features or functionality does
it add? How are they accessed?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
