https://bugzilla.rpmfusion.org/show_bug.cgi?id=5870
Nicolas Chauvet <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Blocks|2 |3
Assignee|rpmfusion-package-review@rp |[email protected]
|mfusion.org |
Flags| |fedora-review?
--- Comment #1 from Nicolas Chauvet <[email protected]> ---
This license state it's redistributable, so good for nonfree.
Why not using %make_build linux ? (seems to work with me).
Koji scratch build succeed on all arches:
https://koji.rpmfusion.org/koji/taskinfo?taskID=456243
* /usr/bin/Generate_Graphs is a little too generic, (and not exectutable perm
despite been in /usr/bin). Worth to move it elsewhere, rename ?
Same for gengnuplot.sh
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/iozone
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v2.0 or
later [obsolete FSF postal address (Temple Place)]". 46 files have
unknown license. Detailed output of licensecheck in
/home/kwizart/review-iozone/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[-]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 317440 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[-]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
echo $version)) missing?
===== SHOULD items =====
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[ ]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define f_ver %(echo %{version}
| tr '.' '_')
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: iozone-3.490-1.fc34.x86_64.rpm
iozone-debuginfo-3.490-1.fc34.x86_64.rpm
iozone-debugsource-3.490-1.fc34.x86_64.rpm
iozone-3.490-1.fc34.src.rpm
iozone.x86_64: W: spelling-error Summary(en_US) Filesystem -> File system,
File-system, Systemically
iozone.x86_64: W: spelling-error Summary(en_US) benchmarking -> bench marking,
bench-marking, benchmark
iozone.x86_64: W: spelling-error %description -l en_US strided -> strides,
stride, striped
iozone.x86_64: W: spelling-error %description -l en_US fread -> dread, read,
fared
iozone.x86_64: W: spelling-error %description -l en_US fwrite -> write, f
write, written
iozone.x86_64: W: spelling-error %description -l en_US pread -> read, spread,
pared
iozone.x86_64: W: spelling-error %description -l en_US mmap -> map, m map,
mamma
iozone.x86_64: W: spelling-error %description -l en_US aio -> air, ail, aid
iozone.x86_64: W: invalid-license Distributable, no modification permitted
iozone.x86_64: W: non-executable-in-bin /usr/bin/Generate_Graphs 644
iozone.x86_64: E: script-without-shebang /usr/bin/Generate_Graphs
iozone.x86_64: E: incorrect-fsf-address /usr/bin/gengnuplot.sh
iozone.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/iozone/Gnuplot.txt
iozone.x86_64: W: no-manual-page-for-binary fileop
iozone.x86_64: W: no-manual-page-for-binary gengnuplot.sh
iozone.x86_64: W: no-manual-page-for-binary iozone_visualizer.pl
iozone.x86_64: W: no-manual-page-for-binary pit_server
iozone-debuginfo.x86_64: W: invalid-license Distributable, no modification
permitted
iozone-debugsource.x86_64: W: invalid-license Distributable, no modification
permitted
iozone.src: W: spelling-error Summary(en_US) Filesystem -> File system,
File-system, Systemically
iozone.src: W: spelling-error Summary(en_US) benchmarking -> bench marking,
bench-marking, benchmark
iozone.src: W: spelling-error %description -l en_US strided -> strides, stride,
striped
iozone.src: W: spelling-error %description -l en_US fread -> dread, read, fared
iozone.src: W: spelling-error %description -l en_US fwrite -> write, f write,
written
iozone.src: W: spelling-error %description -l en_US pread -> read, spread,
pared
iozone.src: W: spelling-error %description -l en_US mmap -> map, m map, mamma
iozone.src: W: spelling-error %description -l en_US aio -> air, ail, aid
iozone.src: W: invalid-license Distributable, no modification permitted
4 packages and 0 specfiles checked; 2 errors, 26 warnings.
Rpmlint (debuginfo)
-------------------
Checking: iozone-debuginfo-3.490-1.fc34.x86_64.rpm
iozone-debuginfo.x86_64: W: invalid-license Distributable, no modification
permitted
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
iozone-debuginfo.x86_64: W: invalid-license Distributable, no modification
permitted
iozone.x86_64: W: spelling-error Summary(en_US) Filesystem -> File system,
File-system, Systemically
iozone.x86_64: W: spelling-error Summary(en_US) benchmarking -> bench marking,
bench-marking, benchmark
iozone.x86_64: W: spelling-error %description -l en_US strided -> strides,
stride, striped
iozone.x86_64: W: spelling-error %description -l en_US fread -> dread, read,
fared
iozone.x86_64: W: spelling-error %description -l en_US fwrite -> write, f
write, written
iozone.x86_64: W: spelling-error %description -l en_US pread -> read, spread,
pared
iozone.x86_64: W: spelling-error %description -l en_US mmap -> map, m map,
mamma
iozone.x86_64: W: spelling-error %description -l en_US aio -> air, ail, aid
iozone.x86_64: W: invalid-license Distributable, no modification permitted
iozone.x86_64: W: non-executable-in-bin /usr/bin/Generate_Graphs 644
iozone.x86_64: E: script-without-shebang /usr/bin/Generate_Graphs
iozone.x86_64: E: incorrect-fsf-address /usr/bin/gengnuplot.sh
iozone.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/iozone/Gnuplot.txt
iozone.x86_64: W: no-manual-page-for-binary fileop
iozone.x86_64: W: no-manual-page-for-binary gengnuplot.sh
iozone.x86_64: W: no-manual-page-for-binary iozone_visualizer.pl
iozone.x86_64: W: no-manual-page-for-binary pit_server
iozone-debugsource.x86_64: W: invalid-license Distributable, no modification
permitted
3 packages and 0 specfiles checked; 2 errors, 17 warnings.
Source checksums
----------------
http://www.iozone.org/docs/Iozone_License.txt :
CHECKSUM(SHA256) this package :
3bff32cedc4a048fd42aceafc2ff66ab5e919f771ffd41e94b17559c03d5098c
CHECKSUM(SHA256) upstream package :
3bff32cedc4a048fd42aceafc2ff66ab5e919f771ffd41e94b17559c03d5098c
http://www.iozone.org/src/current/iozone3_490.tar :
CHECKSUM(SHA256) this package :
5eadb4235ae2a956911204c50ebf2d8d8d59ddcd4a2841a1baf42f3145ad4fed
CHECKSUM(SHA256) upstream package :
5eadb4235ae2a956911204c50ebf2d8d8d59ddcd4a2841a1baf42f3145ad4fed
Requires
--------
iozone (rpmlib, GLIBC filtered):
/usr/bin/perl
/usr/bin/sh
libc.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
iozone-debuginfo (rpmlib, GLIBC filtered):
iozone-debugsource (rpmlib, GLIBC filtered):
Provides
--------
iozone:
iozone
iozone(x86-64)
iozone-debuginfo:
debuginfo(build-id)
iozone-debuginfo
iozone-debuginfo(x86-64)
iozone-debugsource:
iozone-debugsource
iozone-debugsource(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5870
Buildroot used: fedora-rawhide-x86_64
Active plugins: Perl, Generic, C/C++, Shell-api
Disabled plugins: Haskell, SugarActivity, fonts, Java, Ocaml, Python, PHP, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
