https://bugzilla.rpmfusion.org/show_bug.cgi?id=5870
--- Comment #2 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
Thanks for the review!
(In reply to Nicolas Chauvet from comment #1)
> This license state it's redistributable, so good for nonfree.
>
> Why not using %make_build linux ? (seems to work with me).
Fixed.
> Koji scratch build succeed on all arches:
> https://koji.rpmfusion.org/koji/taskinfo?taskID=456243
>
> * /usr/bin/Generate_Graphs is a little too generic, (and not exectutable
> perm despite been in /usr/bin). Worth to move it elsewhere, rename ?
>
> Same for gengnuplot.sh
Agreed. Renamed to iozone_*.
> Issues:
> =======
> - Package does not use a name that already exists.
> Note: A package with this name already exists. Please check
> https://src.fedoraproject.org/rpms/iozone
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/Naming/#_conflicting_package_names
The Fedora package is retired precisely because of the licensing issue.
[...]
> ===== SHOULD items =====
>
> Generic:
> [!]: Uses parallel make %{?_smp_mflags} macro.
> [!]: If the source package does not include license text(s) as a separate
> file from upstream, the packager SHOULD query upstream to include it.
Fixed.
> [!]: Package does not include license text files separate from upstream.
Fixed.
Spec URL: https://www.greysector.net/~rathann/review/iozone/iozone.spec
SRPM URL:
https://www.greysector.net/~rathann/review/iozone/iozone-3.491-1.fc33.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
