https://bugzilla.rpmfusion.org/show_bug.cgi?id=6474
Hans de Goede <h...@hansg.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|rpmfusion-package-review@rp |h...@hansg.org
|mfusion.org |
Flags| |fedora-review?
--- Comment #7 from Hans de Goede <h...@hansg.org> ---
(In reply to Kate Hsuan from comment #6)
> Updated version:
> SPEC:
> https://github.com/smallorange/ipu6-bin-firmware/blob/main/ipu6-camera-bins.
> spec
> SRPM:
> https://github.com/smallorange/ipu6-bin-firmware/releases/download/0.0.1/
> ipu6-camera-bins-0.0-1.20221112git4694ba7.fc38.src.rpm
Thanks for the new version, this looks pretty good to me, just a few small
items remaining to fix:
1. You use:
%setup -q -c
cp %{name}-%{commit}/LICENSE ./
cd %{name}-%{commit}
...
You can replace this with just:
%setup -q -n %{name}-%{commit}
...
And then you can also drop all the %{name}-%{commit}/ prefixes of source files
in %install.
2. License: tag should be Proprietary
3. Please use the same level of indentation after "Summary: " as you do after
the other tags.
4. Please drop the "Provides: %{name}-<subpkg> = %{version}-%{release}" tags
from the subpackages, rpm will add these automatically
5. Please drop the "Requires: %{name} = %{version}-%{release}" from the
firmware subpackage, it does not actually require anything from the main
package.
6. Please move the "Requires: %{name} = %{version}-%{release}" for the
devel subpackage to above the "%description devel".
7. Please drop the "%license LICENSE" from "%files devel", since the devel
subpackage Requires the main package there is no need for it to have a separate
copy of the LICENSE.
Other then these small tweaks I believe that you should drop the
intel-ipu6-kmod-common virtual Provides and that we will need to revive the
intel-ipu6-kmod-common package review and have that be a virtual package (empty
%files list) which can then have Requires on all the bits which we will
eventually need, so from the top of my head:
ipu6-camera-bins-firmware
ivsc-firmware
ipu6-camera-bins
ipu6-camera-hal
gstreamer10-icamerasrc
v4l2-loopback-kmod
v4l2-relayd
Given this long and potentially changing list of Requires necessary to get a
fully working stack I believe just maintaining this inside an otherwise empty
intel-ipu6-kmod-common is probably best, sorry for changing my mind on this.
Note AFAIK the kmod generator will automatically add a dep on
intel-ipu6-kmod-common and we cannot inject other Requires, which is why we
need this virtual package to list the actual Requires.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
