https://bugzilla.rpmfusion.org/show_bug.cgi?id=6474
Hans de Goede <h...@hansg.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #13 from Hans de Goede <h...@hansg.org> ---
Thanks this looks good to me now: approved.
Please follow the next steps at:
https://rpmfusion.org/Contributors#Your_package_gets_approved
2 small remaining nitpicks, please fix these after importing the package:
1. Please use the same indentation between a "Tag-name: " and the value for
that tag-name everywhere and please keeps Tags together rather then adding
unnecessary empty lines inside a block of tags, specifically please change:
%package devel
Summary: IPU6 header files for development.
Requires: %{name}%{?_isa} = %{version}-%{release}
to:
%package devel
Summary: IPU6 header files for development.
Requires: %{name}%{?_isa} = %{version}-%{release}
2. Since the main package already owns %{_libdir}/ipu6 and %{_libdir}/ipu6ep;
and the -devel subpackage requires the main package there is no need for the
-devel subpackage to own these too. Please drop these 2 lines from "%files
devel":
%dir %{_libdir}/ipu6
%dir %{_libdir}/ipu6ep
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
