https://bugzilla.rpmfusion.org/show_bug.cgi?id=7531
--- Comment #9 from Nicolas Chauvet <[email protected]> ---
Okay, this is the raw fedora-review applied to this rfbz
There are a lot of rpmlint issues related to the "headers in non-devel
sub-package", but this is okay since this is a SDK with provided source code.
This package cannot be installed because it relies on the other review.
Also owning %{_prefix}/lib/cmake shall be done on pioasm package, since only
the _libdir counterpart is own by the fedora filesystem package.
Is there any closed source binary component here ? In which case there might be
a need to disable strip on it (or even the debuginfo sub-packages at all).
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Header files in -devel subpackage, if present.
...
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_devel_packages
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/pico-sdk/CONTRIBUTING.md
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file add_copyright.py is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 4194305 bytes in 443 files.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_documentation
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[-]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-Clause License", "BSD 2-Clause
License", "GNU Lesser General Public License, Version 2.1", "Apache
License 2.0", "*No copyright* Apache License 2.0", "MIT License", "*No
copyright* MIT License", "*No copyright* BSD 3-Clause License",
"University of Illinois/NCSA Open Source License", "GNU General Public
License v3.0 or later", "Public domain", "*No copyright* Public
domain", "MIT License and/or The Unlicense", "*No copyright* GNU
General Public License, Version 2", "Apache License 1.0 and/or BSD
3-Clause License", "Apache License 1.0", "BSD 2-clause NetBSD License
and/or BSD 4-Clause License", "Apache License 2.0 [generated file]",
"*No copyright* BSD 0-Clause License", "BSD 3-Clause License and/or
MIT License", "Apache License 2.0 and/or BSD 3-Clause License". 2046
files have unknown license. Detailed output of licensecheck in
/home/kwizart/rpmbuild/review-pico-sdk/licensecheck.txt
[?]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/cmake
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[-]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-] If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ x: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires.
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pico-
sdk-src , pioasm
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_use_rpmlint
[!]: Spec file according to URL is the same as in SRPM.
Note: Bad spec filename: /home/kwizart/rpmbuild/review-pico-sdk/srpm-
unpacked/pico-sdk.spec
See: (this test has no URL)
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Installation errors
-------------------
INFO: mock.py version 6.8 starting (python version = 3.14.7, NVR =
mock-6.8-1.fc44), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64
--no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True
--resultdir=/home/kwizart/rpmbuild/review-pico-sdk/results install
/home/kwizart/rpmbuild/review-pico-sdk/results/pico-sdk-src-2.3.0-1.fc45.noarch.rpm
/home/kwizart/rpmbuild/review-pico-sdk/results/pioasm-2.3.0-1.fc45.x86_64.rpm
/home/kwizart/rpmbuild/review-pico-sdk/results/pico-sdk-2.3.0-1.fc45.x86_64.rpm
/home/kwizart/rpmbuild/review-pico-sdk/results/pioasm-debuginfo-2.3.0-1.fc45.x86_64.rpm
/home/kwizart/rpmbuild/review-pico-sdk/results/pico-sdk-debugsource-2.3.0-1.fc45.x86_64.rpm
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Mock Version: 6.8
INFO: Mock Version: 6.8
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: Package manager dnf5 detected and used (fallback)
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
INFO: Package manager dnf5 detected and used (direct choice)
Finish: chroot init
INFO: installing package(s): /builddir/pico-sdk-src-2.3.0-1.fc45.noarch.rpm
/builddir/pioasm-2.3.0-1.fc45.x86_64.rpm
/builddir/pico-sdk-2.3.0-1.fc45.x86_64.rpm
/builddir/pioasm-debuginfo-2.3.0-1.fc45.x86_64.rpm
/builddir/pico-sdk-debugsource-2.3.0-1.fc45.x86_64.rpm
ERROR: Command failed:
# /usr/bin/systemd-nspawn -q -M 59079b1aa66c423ca005b8ebcd9c33e2 -D
/var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock
--resolv-conf=off --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash
--setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
'--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"'
'--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8
--setenv=LC_MESSAGES=C.UTF-8 /usr/bin/dnf5 --installroot
/var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 46 install
/builddir/pico-sdk-src-2.3.0-1.fc45.noarch.rpm
/builddir/pioasm-2.3.0-1.fc45.x86_64.rpm
/builddir/pico-sdk-2.3.0-1.fc45.x86_64.rpm
/builddir/pioasm-debuginfo-2.3.0-1.fc45.x86_64.rpm
/builddir/pico-sdk-debugsource-2.3.0-1.fc45.x86_64.rpm --setopt=deltarpm=False
--setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts
Rpmlint
-------
Checking: pico-sdk-2.3.0-1.fc45.x86_64.rpm
pico-sdk-src-2.3.0-1.fc45.noarch.rpm
pioasm-2.3.0-1.fc45.x86_64.rpm
pico-sdk-2.3.0-1.fc45.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp14ahea4y')]
checks: 32, packages: 4
pico-sdk-src.noarch: E: zero-length
/usr/share/pico-sdk/cmake/preload/platforms/host.cmake
pico-sdk-src.noarch: E: zero-length
/usr/share/pico-sdk/cmake/preload/toolchains/util/empty.c
pico-sdk-src.noarch: E: zero-length
/usr/share/pico-sdk/lib/btstack/test/pts/sdp.md
pico-sdk-src.noarch: E: zero-length
/usr/share/pico-sdk/lib/btstack/test/sbc/data/sine-4sb-mono.sbc
pico-sdk-src.noarch: E: zero-length
/usr/share/pico-sdk/lib/tinyusb/tools/codespell/exclude-file.txt
pico-sdk-src.noarch: E: spelling-error ('microcontrollers', 'Summary(en_US)
microcontrollers -> micro controllers, micro-controllers')
pico-sdk-src.noarch: E: spelling-error ('microcontroller', '%description -l
en_US microcontroller -> micro controller, micro-controller, agriculturally')
pioasm.x86_64: E: spelling-error ('microcontrollers', '%description -l en_US
microcontrollers -> micro controllers, micro-controllers')
pioasm.x86_64: W: no-manual-page-for-binary pioasm
pico-sdk.x86_64: W: no-documentation
pioasm.x86_64: W: no-documentation
pico-sdk.x86_64: E: no-binary
pico-sdk-src.noarch: W: invalid-license LicenseRef-Raspberry-Pi
pico-sdk-src.noarch: E: files-duplicated-waste 177326
pico-sdk-src.noarch: W: files-duplicate
/usr/share/pico-sdk/docs/logo-mobile.svg
/usr/share/doc/pico-sdk/logo-mobile.svg
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/logo.svg
/usr/share/doc/pico-sdk/logo.svg
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/main.css
/usr/share/doc/pico-sdk/main.css
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/main.js
/usr/share/doc/pico-sdk/main.js
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/normalise.css
/usr/share/doc/pico-sdk/normalise.css
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/pico.jpg
/usr/share/doc/pico-sdk/pico.jpg
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/rp2040.png
/usr/share/doc/pico-sdk/rp2040.png
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/search.svg
/usr/share/doc/pico-sdk/search.svg
pico-sdk-src.noarch: W: files-duplicate /usr/share/pico-sdk/docs/styles.css
/usr/share/doc/pico-sdk/styles.css
pico-sdk-src.noarch: W: files-duplicate
/usr/share/pico-sdk/lib/lwip/src/apps/http/makefsdata/tinydir.h
/usr/share/pico-sdk/lib/btstack/3rd-party/tinydir/tinydir.h
pico-sdk.x86_64: E: explicit-lib-dependency arm-none-eabi-newlib
pico-sdk-src.noarch: W: devel-file-in-non-devel-package
/usr/share/pico-sdk/bazel/include/pico/config_autogen.h
...
idem
...
4 packages and 0 specfiles checked; 11 errors, 2814 warnings, 176 filtered, 11
badness; has taken 11.2 s
Source checksums
----------------
https://github.com/raspberrypi/pico-sdk/archive/2.3.0/pico-sdk-2.3.0.tar.gz :
CHECKSUM(SHA256) this package :
d8ab6e8da66eb54f7ec2e69e3275036704736ba25d6a11be327ecf4a51e068f4
CHECKSUM(SHA256) upstream package :
243fc6c2ae4d1c89d03eba1ba538cb7b92ae2c35ba1d8b80da501f37bcf0763e
https://github.com/hathach/tinyusb/archive/0.18.0/tinyusb-0.18.0.tar.gz :
CHECKSUM(SHA256) this package :
e7fa1bd723213749a0362c79eaccc99e84c8adea8f0a63588c4e4812608b7aa9
CHECKSUM(SHA256) upstream package :
e7fa1bd723213749a0362c79eaccc99e84c8adea8f0a63588c4e4812608b7aa9
https://github.com/georgerobotics/cyw43-driver/archive/v1.1.1/cyw43-driver-1.1.1.tar.gz
:
CHECKSUM(SHA256) this package :
4b41e8153cb44ef18bc80ab68a219e282b7cfbf8a0aa30184e40c957ca55be69
CHECKSUM(SHA256) upstream package :
4b41e8153cb44ef18bc80ab68a219e282b7cfbf8a0aa30184e40c957ca55be69
https://github.com/lwip-tcpip/lwip/archive/STABLE-2_2_1_RELEASE/lwip-STABLE-2_2_1_RELEASE.tar.gz
:
CHECKSUM(SHA256) this package :
ce0b7461c0ad9602c376f0bf07c5eb7253b48c7bf66f011c6bf3e2a96731c539
CHECKSUM(SHA256) upstream package :
ce0b7461c0ad9602c376f0bf07c5eb7253b48c7bf66f011c6bf3e2a96731c539
https://github.com/Mbed-TLS/mbedtls/archive/mbedtls-3.6.6/mbedtls-mbedtls-3.6.6.tar.gz
:
CHECKSUM(SHA256) this package :
de654c64688d0f6c71caf7336010e1fb54070e6e3d1df3999ee432ab59d0dbde
CHECKSUM(SHA256) upstream package :
de654c64688d0f6c71caf7336010e1fb54070e6e3d1df3999ee432ab59d0dbde
https://github.com/bluekitchen/btstack/archive/v1.8.2/btstack-1.8.2.tar.gz :
CHECKSUM(SHA256) this package :
3fc0720d5ca41ab28f0ac6d0006dc5bb8b301557f306ee60ebd9567fb19c2ddd
CHECKSUM(SHA256) upstream package :
3fc0720d5ca41ab28f0ac6d0006dc5bb8b301557f306ee60ebd9567fb19c2ddd
However, diff -r shows no differences
Requires
--------
pico-sdk (rpmlib, GLIBC filtered):
arm-none-eabi-gcc-cs
arm-none-eabi-gcc-cs-c++
arm-none-eabi-newlib
cmake
pico-sdk-src
picotool
pioasm
pico-sdk-src (rpmlib, GLIBC filtered):
/usr/bin/bash
/usr/bin/perl
/usr/bin/python3
/usr/bin/sh
pioasm (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
rtld(GNU_HASH)
Provides
--------
pico-sdk:
pico-sdk
pico-sdk(x86-64)
pico-sdk-src:
bundled(btstack-source)
bundled(cyw43-driver-source)
bundled(lwip-source)
bundled(mbedtls-source)
bundled(tinyusb-source)
pico-sdk-src
pioasm:
pioasm
pioasm(x86-64)
Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=7531
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Perl, C/C++
Disabled plugins: fonts, SugarActivity, R, Ocaml, Java, Python, Haskell, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
