https://bugzilla.rpmfusion.org/show_bug.cgi?id=7531

--- Comment #11 from Elaine Gibson <[email protected]> ---
> There are a lot of rpmlint issues related to the "headers in non-devel
> sub-package", but this is okay since this is a SDK with provided source code.

Oh those are filtered for *-source, I'll revert the name change.

> This package cannot be installed because it relies on the other review.

I can remove that Require if it would make the review easier.

> Also owning %{_prefix}/lib/cmake shall be done on pioasm package, since only
> the _libdir counterpart is own by the fedora filesystem package.

Oops, I saw the i686 version of cmake-filesystem from `dnf rq -f`. Fixed.

> Is there any closed source binary component here ? In which case there might
> be a need to disable strip on it (or even the debuginfo sub-packages at all).

cyw43-driver has firmware blobs in header form, but I don't think there are
closed source binaries shipped.

> You can use the %{url} macro, but it's not mandatory.

I prefer to write it explicitly as it can make sense to change the URL
separately from the download link.

---

Spec URL: https://ypsvlq.fedorapeople.org/pico-sdk.spec
SRPM URL: https://ypsvlq.fedorapeople.org/pico-sdk-2.3.1-1.fc46.src.rpm

- Update to 2.3.1
- Use commits for bundled libraries, btstack was updated to a non-tagged
version so it is probably preferable in general
- Fix directory ownership
- Rename subpackage to -source (preferred in rpmlint)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to