Redbourne,Michael wrote:
1. Assuming this is stable and performant, what is the procedure to submit this to rsyslog? I'm assuming I just fork the repository and create a pull request for impstats.c?
Yes. fork and PR
2. (Again, assume this is stable/performant): What is the likelihood that this type of contribution is accepted? It's not a particularly novel approach, and I haven't seen much discussion around this in the community.
I know that Rainer has been doing some work related to Prometheus, so I would suggest that you check what's happening there. There may be some overlap, or you may need to name things differently (or it may be just fine, Rainer would need to comment)
Rsyslog doesn't handle processing data in arrays well, which may be why this hasn't been in place before.
3. Does rsyslog have a testing pipeline (unit files, etc.) that might help me test functionality? I compiled this in the available stable tarball (8.2508.0) via Rocky EL9.
Yes, when you submit the PR, it will trigger tests. The tests are in the codebase, so you should be able to run them yourself
4. Would this be better contributed as an individual plugin (eg: impstats-prometheus) or as a drop-in replacement for the current impstats module?
This is probably best done as a modification of the existing impstats module, you don't want to duplicate everything (and the problem would then be maintaining it over time)
Just make sure to maintain backwards compatibility. Rsyslog goes to a lot of trouble to make sure that people can upgrade without knowing about new features and modules and not have their system break.
David Lang _______________________________________________ rsyslog mailing list https://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
