Redbourne,Michael wrote:
Renaming it would probably be a good idea for something more fitting... likely
json-array or something. Prometheus is a bit specific. I'll see what Rainer has
to say; see if he has any input on what I'm doing versus what he's currently
working on. I named it Prometheus because that's what our monitoring systems
generally use, and they're all just complex JSON arrays.
question, how large will this message be? how quickly do you run into
maxmessagesize and how do you handle that?
Thank you for the reminder to update the docs. I'll do that now soi it
describes the added functionality and how to use it.
note that the docs have been going through a major series of changes in the last
month or so, so if you modify the doc page from the tarball, you may have to
redo it once you see the current state in git (Rainer has been splitting pages
up, I'm not sure if he's dont impstats yet))
David Lang
________________________________
From: rsyslog <[email protected]> on behalf of David Lang via rsyslog
<[email protected]>
Sent: Monday, September 15, 2025 12:27 PM
To: David Lang via rsyslog <[email protected]>
Cc: David Lang <[email protected]>
Subject: Re: [rsyslog] Code Contributions - New Format for impstats.c
CAUTION: The Sender is located Outside The Organization. Do not click links or
open attachments unless you recognize the sender and know the content is safe.
a couple more things
1. make sure you update the documentation along with your feature
2. work from the git repo rather than a stable release snapshot.
David Lang
On Sun, 14 Sep 2025, David Lang via rsyslog wrote:
Date: Sun, 14 Sep 2025 19:23:57 -0700 (PDT)
From: David Lang via rsyslog <[email protected]>
To: "Redbourne,Michael via rsyslog" <[email protected]>
Cc: David Lang <[email protected]>
Subject: Re: [rsyslog] Code Contributions - New Format for impstats.c
Redbourne,Michael wrote:
1. Assuming this is stable and performant, what is the procedure to submit
this to rsyslog? I'm assuming I just fork the repository and create a pull
request for impstats.c?
Yes. fork and PR
2. (Again, assume this is stable/performant): What is the likelihood that
this type of contribution is accepted? It's not a particularly novel
approach, and I haven't seen much discussion around this in the community.
I know that Rainer has been doing some work related to Prometheus, so I would
suggest that you check what's happening there. There may be some overlap, or
you may need to name things differently (or it may be just fine, Rainer would
need to comment)
Rsyslog doesn't handle processing data in arrays well, which may be why this
hasn't been in place before.
3. Does rsyslog have a testing pipeline (unit files, etc.) that might help
me test functionality? I compiled this in the available stable tarball
(8.2508.0) via Rocky EL9.
Yes, when you submit the PR, it will trigger tests. The tests are in the
codebase, so you should be able to run them yourself
4. Would this be better contributed as an individual plugin (eg:
impstats-prometheus) or as a drop-in replacement for the current impstats
module?
This is probably best done as a modification of the existing impstats module,
you don't want to duplicate everything (and the problem would then be
maintaining it over time)
Just make sure to maintain backwards compatibility. Rsyslog goes to a lot of
trouble to make sure that people can upgrade without knowing about new
features and modules and not have their system break.
David Lang
_______________________________________________
rsyslog mailing list
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.adiscon.net%2Fmailman%2Flistinfo%2Frsyslog&data=05%7C02%7Cmichael.redbourne%40bulletproofsi.com%7Cfe98f1465240403318bb08ddf3ff78df%7C9a63d13853ea411bbe8458b7e2570747%7C1%7C1%7C638935000799573600%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=mIhceyrYSHQYk0r6iO0NSiRemXFGwDOS1wJGh1R%2B4KE%3D&reserved=0<https://lists.adiscon.net/mailman/listinfo/rsyslog>
https://can01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.rsyslog.com%2Fprofessional-services%2F&data=05%7C02%7Cmichael.redbourne%40bulletproofsi.com%7Cfe98f1465240403318bb08ddf3ff78df%7C9a63d13853ea411bbe8458b7e2570747%7C1%7C1%7C638935000799597263%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=%2Fq%2Fk5tkMbA10P9zqh2kyMvsJ7Wt9Y%2B3GshzVFJpE%2BaU%3D&reserved=0<http://www.rsyslog.com/professional-services/>
What's up with rsyslog? Follow
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Frgerhards&data=05%7C02%7Cmichael.redbourne%40bulletproofsi.com%7Cfe98f1465240403318bb08ddf3ff78df%7C9a63d13853ea411bbe8458b7e2570747%7C1%7C1%7C638935000799611844%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=7MtMNpzb3QmYr57O8A8ZfphY2ybC8vmh9dYfiSZqilA%3D&reserved=0<https://twitter.com/rgerhards>
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T
LIKE THAT.
_______________________________________________
rsyslog mailing list
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.adiscon.net%2Fmailman%2Flistinfo%2Frsyslog&data=05%7C02%7Cmichael.redbourne%40bulletproofsi.com%7Cfe98f1465240403318bb08ddf3ff78df%7C9a63d13853ea411bbe8458b7e2570747%7C1%7C1%7C638935000799625179%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=VhiYrhC5pjQ9y3iRTuGNObqHNbE0vCsPTLYxJsc9%2BT0%3D&reserved=0<https://lists.adiscon.net/mailman/listinfo/rsyslog>
https://can01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.rsyslog.com%2Fprofessional-services%2F&data=05%7C02%7Cmichael.redbourne%40bulletproofsi.com%7Cfe98f1465240403318bb08ddf3ff78df%7C9a63d13853ea411bbe8458b7e2570747%7C1%7C1%7C638935000799638445%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=SubYC1JDGj9gV9VL6XbwKB34SEbXTjiGpaQc%2Baxk040%3D&reserved=0<http://www.rsyslog.com/professional-services/>
What's up with rsyslog? Follow
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Frgerhards&data=05%7C02%7Cmichael.redbourne%40bulletproofsi.com%7Cfe98f1465240403318bb08ddf3ff78df%7C9a63d13853ea411bbe8458b7e2570747%7C1%7C1%7C638935000799651326%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=AhTzfjj6Ab3JbI%2Fstz5khTY75mKnc3pgc5KXYKR13TU%3D&reserved=0<https://twitter.com/rgerhards>
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
________________________________________
This e-mail communication (including any or all attachments) is intended only
for the use of the person or entity to which it is addressed and may contain
confidential and/or privileged material. If you are not the intended recipient
of this e-mail, any use, review, retransmission, distribution, dissemination,
copying, printing, or other use of, or taking of any action in reliance upon
this e-mail, is strictly prohibited. If you have received this e-mail in error,
please contact the sender and delete the original and any copy of this e-mail
and any printout thereof, immediately. If you have any questions or concerns,
please contact our Customer Service Desk at 1-877-274-2349. Your co-operation
is appreciated.
Le pr?sent courriel (y compris toute pi?ce jointe) s'adresse uniquement ? son
destinataire, qu'il soit une personne ou un organisme, et pourrait comporter
des renseignements privil?gi?s ou confidentiels. Si vous n'?tes pas le
destinataire du courriel, il est interdit d'utiliser, de revoir, de
retransmettre, de distribuer, de diss?miner, de copier ou d'imprimer ce
courriel, d'agir en vous y fiant ou de vous en servir de toute autre fa?on. Si
vous avez re?u le pr?sent courriel par erreur, pri?re de communiquer avec
l'exp?diteur et d'?liminer l'original du courriel, ainsi que toute copie
?lectronique ou imprim?e de celui-ci, imm?diatement. Si vous avez des questions
ou des pr?occupations, veuillez contacter notre centre de service ? la
client?le au 1-877-274-2349. Nous sommes reconnaissants de votre collaboration.
________________________________________
_______________________________________________
rsyslog mailing list
https://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
