In specific, I believe that this would be the better patch:
--- html/Elements/MessageBox_orig 2009-01-28 23:48:34.000000000
-0800
+++ html/Elements/MessageBox 2009-01-28 23:48:45.000000000 -0800
@@ -60,7 +60,7 @@
my $signature = '';
if ( $IncludeSignature and my $text = $session{'CurrentUser'}-
>UserObj->Signature ) {
- $signature = "-- \n". $text;
+ $signature = "\n\n\n-- \n". $text;
}
</%INIT>
Jesse: I can't find any place where the Signature and "-- \n" are
being used for empty reply comparison. Can you point me in the right
direction? The obvious fix is \s+\-\-\s\n + Signature but I can't
find where this should go.
On Jan 28, 2009, at 11:43 PM, Jo Rhett wrote:
This is patching the wrong way, but it's the right decision. I'm
hating having to manually move the cursor in front of the signature
and end a newline before typing.
I think the right patch would be to add the whitespace at the same
place that "-- \n" is added to the beginning of the signature. This
is only added if the signature exists, and thus would be the easy fix.
On Jan 28, 2009, at 8:15 PM, Adam Tingle wrote:
Thanks for the heads-up, but how does the empty reply detection
work? It doesn't seem to do anything if I remove the patch. I click
reply, click update ticket, and my 'empty reply' is recorded. Is it
an option I have to turn on?
- Adam
On Wed, Jan 28, 2009 at 10:58 PM, Jesse Vincent <je...@bestpractical.com
> wrote:
Be careful. This patch will break rt's empty reply detection.
Adam Tingle <adamtin...@gmail.com> wrote:
>Hi rt-users,
>
>Here's a quick patch I made to add some whitespace to the top of
the message
>when replying to a message. It makes it easier to just start
typing if you
>have FCKeditor set to StartupFocus.
>
>
>--- MessageBox 2009-01-28 21:37:01.000000000 -0500
>+++ /usr/local/share/request-tracker3.8/html/Elements/MessageBox
>2009-01-28 22:28:23.000000000 -0500
>@@ -47,7 +47,7 @@
> %# END BPS TAGGED BLOCK }}}
> <textarea class="messagebox" cols="<% $Width %>" rows="<% $Height
%>"
>wrap="<% $Wrap %>" name="<% $Name %>">\
> % $m->callback( %ARGS );
>-<% $Default || '' %><% $message %><% $signature %></textarea>
>+<% $Default || '' %><% $whitespace %><% $message %><% $signature
>%></textarea>
> <%INIT>
>
> my $message = '';
>@@ -63,6 +63,10 @@
> $signature = "-- \n". $text;
> }
>
>+my $whitespace = '';
>+if ( $message ) {
>+ $whitespace = "\n\n\n";
>+}
> </%INIT>
> <%ARGS>
> $QuoteTransaction => undef
>
>
>BTW, I caught on that making changes in
>local/html/NoAuth/RichText/FCKeditor/fckconfig.js doesn't work;
where's the
>best place to override the FCKeditor configuration to enable the
option
>FCKConfig.StartupFocus = true; ? Even better, how about making
this the
>default option, as no other fields seem to get the focus anyway.
>
>--
>...................
>Adam Tingle
>_______________________________________________
>http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
>
>Community help: http://wiki.bestpractical.com
>Commercial support: sa...@bestpractical.com
>
>
>Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
>Buy a copy at http://rtbook.bestpractical.com
--
Sent from my Android phone with K-9. Please excuse my brevity.
--
...................
Adam Tingle
_______________________________________________
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
Community help: http://wiki.bestpractical.com
Commercial support: sa...@bestpractical.com
Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
Buy a copy at http://rtbook.bestpractical.com
--
Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness
--
Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness
_______________________________________________
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
Community help: http://wiki.bestpractical.com
Commercial support: sa...@bestpractical.com
Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
Buy a copy at http://rtbook.bestpractical.com
