On Mon, Mar 06, 2017 at 12:04:24AM -0700, Logan Gunthorpe wrote: > From: Jason Gunthorpe <[email protected]> > > The use after free is not triggerable here because the cdev holds > the module lock and the only device_unregister is only triggered by > module unload, however make the change for consistency. > > To make this work the cdev_del needs to move out of the struct device > release function. > > This cleans up the error path significantly and thus also fixes a minor > bug where the devnum would not be released if cdev_add failed. > > Signed-off-by: Jason Gunthorpe <[email protected]> > Signed-off-by: Logan Gunthorpe <[email protected]> > Reviewed-by: Logan Gunthorpe <[email protected]> > ---
Thanks, Reviewed-by: Leon Romanovsky <[email protected]> -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
