On 2013-05-27 07:45, Jan Kiszka wrote: > On 2013-05-19 10:24, Manuel Huber wrote: >> Hello! >> >> I'm currently working on a patch for RTnet >> (https://bitbucket.org/robinreal/rtnetts/overview exp branch) that >> enables the user to retrieve time stamps from the driver (via >> recvmsg). Currently development is not finished, there are still >> bugs and I need to rewrite commit messages. Overview: >> >> * I hooked into the rt_udp_recvmsg function to optionally add time >> stamps to the msghdr struct. The rt_socket_recv_timestamp function >> is used to actually retrieve put the time stamp into the cmsg >> buffer. This could maybe also be used for other protocols (?). >> >> * In stack/scm.c the original put_cmsg function has been ported to >> RTDM. Currently I haven't yet implemented the put_cmsg_compat >> function. >> >> * In rtnet_socket.h I added a member sk_flags, which could be used for >> various other functions. This is used to activate and deactivate >> passing time stamps to the user (through msghdr structure). >> >> * CONFIG_RTNET_SO_TIMESTAMPNS can be used to control whether RTnet >> stack supports passing timestamps to user-space or not. > > Still need to study this. Will have a look these days while traveling.
First remark: You are mixing changes of different kind in your commits. Specifically changes to generated autotools are better kept separate from code changes (including changes to autotools input files). Same for coding style changes. That will ease the review later on. Fortunately, git allows you reorganize things as often as you like ;). Oh, and something is fairly broken in your tree over there. Looks like one commit deletes all the generated autotools files... BTW, I don't think this feature has to be optional at compile time. It only adds a single if to the hotpath, not really expensive. And you should really measure the difference between TIMESTAMPNS64 and TIMESTAMPNS. What is your target arch? Jan
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________ RTnet-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/rtnet-developers
