Hi Sinisa, Siniša Denić wrote: > Hi Jan, > > I have finished porting Atmel MACB Ethernet > driver to RTDM, it stays in attachment. > I think it is not the end > of this job, but now it is working for me. > I didn't taste it in IP environment because we use it on > data-link layer with MAC addresses. > I also think that driver > is a bit complicated, and for RTnet can be much simpler but I didn't want > break original author's idea.I simply followed it. > There are some opacities for me in original driver.It is about disabling > interrupts - at two points in main > driver's ISR: > - there is > 'macb_writel(bp, IDR, ~0UL)' line which disables all other interrupts, but > no one enables it again I didn't find out where it would be > > - and 'macb_writel(bp, IDR, MACB_RX_INT_FLAGS)' with same > situation > This is work for me because we have specific > situation.Net traffic is point to point and CPU communicates with slaves by > ehtercat with only one packet running around.I'm afraid that for general > purpose at least 2nd line of these must be enabled. > I > also put mii.c in one file, maybe I didn't have to do it but I've wanted to > get driver at once. > There is also macb_poll function which isn't > used and maybe it can be missed. > One more thing which maybe have > to be consider is 'budget' in macb_rx function,If I understood it is > nomber of frames, which can be received in RX buffers, I put it > approximately. > I hope you will take a look at code when you will > be able, > and attach it on rtnet-svn as our contribiton.
Thanks for your contribution! I will look into this - once time permits :-/. Not mandatory to get it merged, but even nicer for me to prepare it would be a patch against the SVN trunk. This should include also the Makefile changes. What is required for this can be seen quite nicely in the rt_at91_ether merge [1] (minus *.in and configure, those are auto-generated). Jan [1] http://rtnet.svn.sourceforge.net/viewvc/rtnet?view=rev&revision=1140
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ RTnet-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/rtnet-users
