Dne 20. 11. 20 v 17:02 Pavel Valena napsal(a):
----- Original Message -----Sent: Friday, November 20, 2020 10:51:46 AM Subject: Re: Ruby 3.0What if we provided `%{ruby_vendorlibdir}/rbconfig.rb`, which would fix the `CXX` as well as the rhbz#1284684? WDYT?I'm not entirely sure how that'd work TBH. Would it override the original `rbconfig.rb`? Would it just override some entries? Or completely replace it?
The original rbconfig.rb would stay in place. But the `vendorlibdir` gets precedence on load patch, so it would be loaded first, later loading the original rbconfig and modifying what is necessary. It could possibly return values according to the current setup, i.e. provide `CONFIG['CXX']` when c++ compiler is installed, modifying the configuration options depending if the rpm-redhat-config is installed etc.
What's the advantage compared to modifying `rbconfig.rb`?
Modifying anything is problematic. Sed silently fails, patch fails to apply, etc ... But it would be options of course.
Anyway, if unsure, is there something (prefered solution) I could test at least? (I'm not sure what's the best way to address that issue- more bellow.) I don't feel like just simply overriding `rbconfig.rb` file in `%install` for ruby. Also I'm not sure what would be the implications? (Apart from those test packages building again.)Vít Dne 20. 11. 20 v 1:59 Pavel Valena napsal(a):----- Original Message -----From: "Vít Ondruch" <vondr...@redhat.com> To: ruby-sig@lists.fedoraproject.org Sent: Thursday, November 19, 2020 6:12:01 PM Subject: Re: Ruby 3.0 @Pavel, could you please try to add `%{set_build_flags}` call prior calling the `%gem_install`? That sets the `CXX` env variable. Does it help?Sure, - https://copr.fedorainfracloud.org/coprs/build/1775666 https://copr.fedorainfracloud.org/coprs/build/1775665 I'm afraid it didn't help. I've also tried setting CXX explicitly, and/or adding this: +sed -i "1i RbConfig::MAKEFILE_CONFIG['CXX'] = 'g++'" \ + ext/extconf.rb But it fails all the same. Here's another try, using CONFIG['CXX'] = 'g++': https://copr.fedorainfracloud.org/coprs/build/1775762This one has failed as well. Any ideas on what I can modify in the gem package build to make it work? (Without recreating whole `rbconfig.rb`.)
There are two extensions in Eventmachine. You have fixed extconf.rb just for one (should you choose go this path).
Vít
Regards, PavelPavelVítSo CONFIG["CXX"] is not yet set ( in /usr/lib64/ruby/rbconfig.rb on x86_64) (see: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org/message/HJHP53TYDQ2NTWZB3WDNL6X4RCVYRAID/ ) and still rubygem-eventmachine fails to find CXX compiler, while rawhide ruby-libs rpm has CONFIG["CXX"] value. Regards, Mamoru_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
