And this is now used in Ruby. Please see the changes in the PR:

https://src.fedoraproject.org/rpms/ruby/pull-request/159

https://src.fedoraproject.org/fork/vondruch/rpms/ruby/c/6d8ecfca02947b5f1ce48cc51943e5f127d93be2
https://src.fedoraproject.org/fork/vondruch/rpms/ruby/c/865f5b3a896ed1b423add7ffe0601707155828ef

And the associated build is running here:

https://koji.fedoraproject.org/koji/taskinfo?taskID=107710823

Yes, this is the latest snapshot. So please give it a proper test. And thx for all the feedback (yes, I remember I have to check the RubyGems, but I wanted to finish the generators first).


Vít



Dne 16. 10. 23 v 16:19 Vít Ondruch napsal(a):

Dne 12. 10. 23 v 17:20 Vít Ondruch napsal(a):

Next on my table is allow usage of generators on default/bundled gems. More details on this approach is here:

https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/3MHROKOM53HM6NF7RGGLFBIQFG5IEIQG/

and in practice, this will look like:


~~~

$ git diff
diff --git a/ruby.spec b/ruby.spec
index 1aea20b..51f3065 100644
--- a/ruby.spec
+++ b/ruby.spec
@@ -196,6 +196,11 @@ Source15: test_openssl_fips.rb
 %{load:%{SOURCE4}}
 %{load:%{SOURCE5}}

+%global __local_generator_requires make -C %{_builddir}/%{buildsubdir}/%{_vpath_builddir} -s runruby TESTRUN_SCRIPT="--enable-gems %{SOURCE9}" +%global __local_generator_provides make -C %{_builddir}/%{buildsubdir}/%{_vpath_builddir} -s runruby TESTRUN_SCRIPT="--enable-gems %{SOURCE10}" +%global __local_generator_conflicts make -C %{_builddir}/%{buildsubdir}/%{_vpath_builddir} -s runruby TESTRUN_SCRIPT="--enable-gems %{SOURCE11}"
+%global __local_generator_path ^%{gem_dir}/specifications/.*\.gemspec$
+
 # Fix ruby_version abuse.
 # https://bugs.ruby-lang.org/issues/11002
 Patch0: ruby-2.3.0-ruby_version.patch
@@ -229,6 +234,7 @@ Requires: %{name}-libs%{?_isa} = %{version}-%{release}
 Recommends: ruby(rubygems) >= %{rubygems_version}
 Recommends: rubygem(bigdecimal) >= %{bigdecimal_version}

+BuildRequires: rpm-local-generator-support
 # Build dependencies
 BuildRequires: autoconf
 BuildRequires: gcc

~~~


But to enable this, I'll soon need help with a review of:

https://copr.fedorainfracloud.org/coprs/vondruch/rpm-local-generator/package/rpm-local-generator-support/



I have submitted this package for a review. Can somebody help me please? The package can't be simpler.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2244428

Thx in advance

BTW it shaves off ~60 lines of the ruby.spec


Vít

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to