Vít Ondruch wrote on 2023/12/11 21:26:
Hi everybody,
Ruby 3.3 RC1 is here:
https://www.ruby-lang.org/en/news/2023/12/11/ruby-3-3-0-rc1-released/
And therefore I have updated the PR with recent changes and the build is
running here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=110183096
I have not seen anything what would caught my attention. And I hope that there
won't be any big changes since now, because upstream promises stable ABI with
RC1:
https://bugs.ruby-lang.org/issues/19980#note-3
We will see. As always, any feedback is welcome.
Vít
Okay, thank you.
Now I've again tried rebuilding all rubygem-XXX packages with
https://github.com/ruby/ruby/commit/505715ddf17e004d184c0b71afb40a31e2e8c98e
(later than ruby-3.3RC1 commit) (with additional notes).
The results are again shown as below.
Now 10 packages are failing to build:
A. The following 6 packages are failing due to the same reasons as before:
1. rubygem-actionview
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743492/
2. rubygem-aruba
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743493/
3. rubygem-async_sinatra
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743494/
4. rubygem-byebug
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743496/
5. rubygem-childprocess
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743497/
6. rubygem-ronn-ng
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743511/
B. The following packages failed to build, build failure was occuring from
before, but
this time failed with the different reasons than before
7. rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743510/
Test suite expects some output, but actual output shows some diffs than
expected like:
```
F
Failure:
ApplicationTests::BinSetupTest#test_bin_setup_output
[test/application/bin_setup_test.rb:51]:
--- expected
+++ actual
@@ -2,10 +2,22 @@
The Gemfile's dependencies are satisfied
== Preparing database ==
+/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/message_verifier.rb:4:
warning: base64 was loaded from the standard library, but will no longer be
part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or
gemspec. Also contact author of activesupport-7.0.8 to add base64 into its
gemspec.
+/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/core_ext/object/json.rb:5:
warning: bigdecimal was loaded from the standard library, but will no longer
be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or
gemspec. Also contact author of activesupport-7.0.8 to add bigdecimal into its
gemspec.
+/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/notifications/fanout.rb:3:
warning: mutex_m was loaded from the standard library, but will no longer be
part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or
gemspec. Also contact author of activesupport-7.0.8 to add mutex_m into its
gemspec.
+/usr/share/gems/gems/mail-2.7.1/lib/mail.rb:9: warning: net/smtp was loaded
from the standard library, but is not part of the default gems since Ruby
3.1.0. Add net-smtp to your Gemfile or gemspec. Also contact author of
mail-2.7.1 to add net-smtp into its gemspec.
Created database 'app_development'
Created database 'app_test'
```
C. New failures
8. rubygem-rails-deprecated_sanitizer
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743508/
```
1) Failure:
DeprecatedSanitizerTest#test_Action_View_sanitizer_vendor_returns_constant_from_HTML_module
[/builddir/build/BUILD/rails-deprecated_sanitizer-1.0.4/usr/share/gems/gems/rails-deprecated_sanitizer-1.0.4/test/deprecated_sanitizer_test.rb:15]:
Expected: HTML::LinkSanitizer
Actual: Rails::HTML4::LinkSanitizer
```
Most likely due to rubygem-rails-html-sanitizer update from 1.4.3 to 1.6.0,
especially
perhaps due to this commit:
https://github.com/rails/rails-html-sanitizer/commit/206942674e5fb16e90d777de6e3debc842fe9b6c
Maybe just fixing rails-deprecated_sanitizer testsuite is fine, but I am not
sure.
Note that rawhide koschei build is also failing:
https://koschei.fedoraproject.org/package/rubygem-rails-deprecated_sanitizer?collection=f40
9. rubygem-rubygems-mirror
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/build/6743512/
```
+ ruby -Ilib -e 'Dir.glob "./test/test_*.rb", &method(:require)'
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:127:in
`require': cannot load such file -- rubygems/indexer (LoadError)
from
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:127:in
`require'
from
/builddir/build/BUILD/rubygems-mirror-1.3.0/usr/share/gems/gems/rubygems-mirror-1.3.0/lib/rubygems/mirror/test_setup.rb:7:in
`<top (required)>'
from
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:127:in
`require'
from
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:127:in
`require'
from
/builddir/build/BUILD/rubygems-mirror-1.3.0/usr/share/gems/gems/rubygems-mirror-1.3.0/test/test_gem_mirror.rb:3:in
`<top (required)>'
from
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:127:in
`require'
from
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:127:in
`require'
from <internal:dir>:411:in `glob'
from -e:1:in `<main>'
```
This is due to:
https://github.com/ruby/ruby/commit/4817166e54ad98f9b3e9d06e9e8c7ccff992a957
Maybe packaging rubygem-rubygems-generate_index rpm is needed.
10. rubygem-puma
Well, actually the testsuite of this package seems very flaky...
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/package/rubygem-puma/
Maybe testsuite again gets successful when I resubmit build when the
overload
on copr build server is low, I am not sure.
Notes:
D. rubygem-liquid (which was previously failing to build) now fixed with
applying upstream PR.
E. Actually the following packages fail to build with ruby
commit:505715ddf17e004d184c0b71afb40a31e2e8c98e
as well as with ruby 3.3RC1:
* rubygem-eventmachine
* rubygem-log4r
It turned out to be exactly due to: https://bugs.ruby-lang.org/issues/20048
(UDPSocket getaddrinfo issue).
I've verified that now the above 2 packages successfully build after:
https://github.com/ruby/ruby/commit/25711e7063060920d14e42a530da6f7198926629
Anyway I think now ruby 3.3 state is almost good.
Regards,
Mamoru
--
_______________________________________________
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
