Dne 13. 12. 23 v 13:44 Mamoru TASAKA napsal(a):
Vít Ondruch wrote on 2023/12/11 21:26:
Hi everybody,

Ruby 3.3 RC1 is here:

https://www.ruby-lang.org/en/news/2023/12/11/ruby-3-3-0-rc1-released/

And therefore I have updated the PR with recent changes and the build is running here:

https://koji.fedoraproject.org/koji/taskinfo?taskID=110183096

I have not seen anything what would caught my attention. And I hope that there won't be any big changes since now, because upstream promises stable ABI with RC1:

https://bugs.ruby-lang.org/issues/19980#note-3

We will see. As always, any feedback is welcome.


Vít


Another Umm....

Now
* Build OK https://github.com/ruby/ruby/commit/2350c7946275cd570cc1d7cd892abc16ac68a92c * Build FAIL https://github.com/ruby/ruby/commit/75f4a687ed54e3b1863ba1767c666a0bea809c8a

Failing like:

```
+ make -C redhat-linux-build -s runruby 'TESTRUN_SCRIPT=-e " module Bundler; module Persistent; module Net; module HTTP;   end; end; end; end;   require '\''bundler/vendor/net-http-persistent/lib/net/http/persistent'\''; puts '\''%{bundler_net_http_persistent_version}: 4.0.2'\'';   puts %Q[Bundler::Persistent::Net::HTTP::Persistent::VERSION: #{Bundler::Persistent::Net::HTTP::Persistent::VERSION}];   exit 1 if Bundler::Persistent::Net::HTTP::Persistent::VERSION != '\''4.0.2'\''; "' /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/timeout/lib/timeout.rb:25:in `<top (required)>': uninitialized constant Gem (NameError)     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/net-protocol/lib/net/protocol.rb:23:in `require_relative'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/net-protocol/lib/net/protocol.rb:23:in `<top (required)>'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/net-http/lib/net/http.rb:23:in `require_relative'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/net-http/lib/net/http.rb:23:in `<top (required)>'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/net/http.rb:3:in `require_relative'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/rubygems/net/http.rb:3:in `<top (required)>'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/bundler/vendored_net_http.rb:4:in `require'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/bundler/vendored_net_http.rb:4:in `<top (required)>'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb:1:in `require_relative'     from /builddir/build/BUILD/ruby-3.3.0-745ab3e4c7/lib/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb:1:in `<top (required)>'
    from -e:1:in `require'
    from -e:1:in `<main>'
make: *** [uncommon.mk:1375: runruby] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.Dh4Yrz (%check)
    Bad exit status from /var/tmp/rpm-tmp.Dh4Yrz (%check)
```


This should be the medicine:


~~~

@@ -924,12 +983,12 @@ make -C %{_vpath_builddir} -s runruby TESTRUN_SCRIPT="-e \" \
 # constant Gem (NameError) issue.
 # https://github.com/rubygems/rubygems/issues/5119
 make -C %{_vpath_builddir} -s runruby TESTRUN_SCRIPT="-e \" \
-  module Bundler; module Persistent; module Net; module HTTP; \
-  end; end; end; end; \
+  module Gem; end; \
+  module Bundler; end; \
   require 'bundler/vendor/net-http-persistent/lib/net/http/persistent'; \
   puts '%%{bundler_net_http_persistent_version}: %{bundler_net_http_persistent_version}'; \ -  puts %Q[Bundler::Persistent::Net::HTTP::Persistent::VERSION: #{Bundler::Persistent::Net::HTTP::Persistent::VERSION}]; \ -  exit 1 if Bundler::Persistent::Net::HTTP::Persistent::VERSION != '%{bundler_net_http_persistent_version}'; \ +  puts %Q[Gem::Net::HTTP::Persistent::VERSION: #{Gem::Net::HTTP::Persistent::VERSION}]; \ +  exit 1 if Gem::Net::HTTP::Persistent::VERSION != '%{bundler_net_http_persistent_version}'; \
 \""

 # Thor.

~~~


Looking at:
https://github.com/ruby/ruby/compare/2350c79462...75f4a687ed54e3b1863ba1767c666a0bea809c8a
I suspect the above failure is related to:
https://github.com/ruby/ruby/commit/ce924ce1fb029f19fd34a43f2012a485f4f62b53


This is the upstream PR for more details:


https://github.com/rubygems/rubygems/pull/6793


Vít



Vít, would you have a look at this? Thank you.

Regards,
Mamoru

--
_______________________________________________
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

--
_______________________________________________
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to