(repost from the ticket comment for the benefit of the mailing list)

I hit Filter in the wrong place error for a different scenario.

My scenario is that I have a before_filter that was raising an
exception, and the around_filter rescuing it with a render / redirect.
I have included test cases for this scenario as well as the scenario
when the action itself raising an exception.

I have included a one-liner patch that basically just returns before
it gets the chance to raise the Filter in wrong place exception if
performed? is true. Seems to work, and all tests pass but I don't know
if this is right.

I have also included the original test case above by nik.wakelin to
test that this patch works.

http://dev.rubyonrails.org/ticket/8803

Regards,
kamal

On Jun 29, 1:03 pm, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> There is a ticket with a failing test case attached 
> at:http://dev.rubyonrails.org/ticket/8803
>
> Cheers,
>
> Nik
>
> On May 6, 2:19 pm, "Michael Koziarski" <[EMAIL PROTECTED]> wrote:
>
> > > I'm using a Pistonized Rails export from the 1.2 branch.  I just
> > > updated to r6651 and got the new implementation.  Running functional
> > > and integration tests reveals nothing, as well as running under
> > > Mongrel in development mode.
>
> > > After deploying to a staging server (in production mode), I get the
> > > following failure:
>
> > Hmm, this could be a pain to track down.  Can you reproduce it with a
> > simple sample application?
>
> > > I received a similar failure for anotherfilterthat is added using
> > > prepend_before_filter.
>
> > > Any change I did somethingwrong?
>
> > Seems ok to me from what you've described....
>
> > > Thanks !
> > > --
> > > François Beausoleil
> > >http://blog.teksol.info/
> > >http://piston.rubyforge.org/
>
> > --
> > Cheers
>
> > Koz


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to