Yes we could do that. The question in this case is whether we want to distinguish between around filters returning false and filters that simply don't yield w.r.t. after filter processing.
we could say that an around filter returning false will stop after filter processing whereas filters that simply don't yield will not stop the after filter chain. and while we're at it: I suggest that it should be possible for after filters to stop after filter chain processing by returning false. On 7/7/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > > > The patch is here: http://dev.rubyonrails.org/ticket/8891 > > I've forgotten why the return false was required for around filters. > Couldn't we do: > > yielded = false > filter.call(self) do > yielded = true > # all remaining before and around filters will be run in this call > index = call_filters(chain, index.next, nesting.next) > end > halt_filter_chain(filter) unless yielded > > > -- > Cheers > > Koz > > > > -- -- For rails performance tuning, see: http://railsexpress.de/blog Subscription: http://railsexpress.de/blog/xml/rss20/feed.xml --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
