> What are the practical implications of these issues that you're > describing? I guess I'm just not following you?
We're talking about how some test files are defining identifiers in the global namespace which are affecting each other, possibly causing different results when the tests are run alone or in a different order. In this case it's just repeated definitions which need to be placed elsewhere. But, it seems like there should be a hard and fast rule in testing against placing anything mutable in the global namespace, lest another test reference it and get different results. > The tests could certainly be broken up to have all the controllers > defined in seperate files. However they're still going be run in one > interpreter. Yes, but as long as they're all using the same controller, rather than using different ones that could clobber each other differently based on test order and cause undefined results, I'd count it as an improvement. But truly, finding a way to purge this information between tests would be quite beneficial! > The best I can find through a quick trawl is > actionpack/test/controller/controller_fixtures/app/models, but there's no > directory there currently and it seems a bit presumptuous to be creating new > directories with my first real patch. <grin> Hehe, go ahead. I've been meaning to tear into this source tree, though I'm a little timid about submitting monster patch files that might break other people's pending patches. What would be really nice would be for someone with cvs write access to take care of this, after skimming through the ticket tracker and applying any relevant actionpack/test-related patches. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
