It's even more purely a bikeshed discussion than you mention, as there's no particular reason this would break code that inherits from ActiveRecord::Base. Again:
class ActiveRecord Base = self end Problem solved. If we want to purge ::Base, depricate it and remove it several versions later. The bigger problem is code which naively does this: module ActiveRecord ... end And I've found this to be a better practice anyway, especially with Rails autoloading: ActiveRecord.module_eval do ... end Which would work just fine, whether it's a module or a class. In other words: This isn't likely to break much code. It is very much a question of taste. No one's suggesting that we rebuild the bikeshed, or change the locks -- only painting it a different color. On Mon, Oct 13, 2008 at 8:01 PM, Nate Wiger <[EMAIL PROTECTED]> wrote: > > Can I just add that, since this is purely a bikeshed discussion, and > there is TONS of code that inherits from ActiveRecord::Base (and > others), there is no reason to repaint everyone's bikeshed red just to > satisfy the few people that have mentioned casually that they don't > really like blue? > > I suspect you'd hear quite the uproar breaking such a huge piece of > compatibility. It is the way it is. > > On a related note, the "internals" change of Inflector -> > ActiveSupport::Inflector and Dependencies -> > ActiveSupport::Dependencies in Rails 2.1.1 actually broke alot of my > code that was in Rakefiles and other places that was taking advantage > of these very cool Rails modules. For this reason we're stuck on > Rails 2.1.0 until we can lockstep upgrade everything. It's actually a > huge pain in the butt, again for a needless bikeshed change. > > "Better" or "prettier" or "more proper" should never trump > "incompatible". > > -Nate > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
