Done: https://rails.lighthouseapp.com/projects/8994/tickets/2659-paramsparser-and-request-body-streams#ticket-2659-3
Let me know if you need anything else. -Brian On May 16, 7:22 pm, Joshua Peek <j...@joshpeek.com> wrote: > Yeah, create a LH patch and assign it to me plz > > > > > > On Sat, May 16, 2009 at 6:01 PM, brianmario <seniorlo...@gmail.com> wrote: > > > Ok I forked and patched the ParamsParser to just pass request.body to > > the parsers. I did it for JSON, XML and YAML (using YAML.load_stream > > instead of just load). > > I also patched the XmlMini and JSON decoders for parsing from an IO, > > in addition to a string. And as a result (like you said), I didn't > > have to refactor any tests. Just added the ones regarding parsing from > > an IO. > > The one test I haven't figured out how to write, is the "that the > > ParamsParser middleware doesn't read the entire stream into a string > > itself." test. I can imagine how I might do it using rspec/mocha but > > no idea using Test::Unit. > > > Here's the commit: > >http://github.com/brianmario/rails/commit/c63703489eb1f3f4dd96885e1e2... > > > Feedback? > > > Also, should I make a lighthouse ticket for this? > > > -Brian > > > On May 16, 9:44 am, Mislav Marohnić <mislav.maroh...@gmail.com> wrote: > >> On Sat, May 16, 2009 at 09:54, brianmario <seniorlo...@gmail.com> wrote: > > >> > Exactly. > > >> > What's the next step here? > >> > I can fork Rails and work on a patch, though I'm unsure how many/which > >> > tests will need to be refactored. > > >> I don't think existing tests need changes. New tests have to be added: > > >> 1. that JSON parser works with an IO; > >> 2. that XML parser works with an IO; > >> 3. that the ParamsParser middleware doesn't read the entire stream into > >> a > >> string itself. > > -- > Joshua Peek --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
