Nope it wouldn't. Rendering the emails don't currently raise errors, so your tests will still pass. The only way to find out is to actually get the email and click on it. Even if you look at it in mail_view you get the right URL generated as the relative path will work.
Right now it's all just :( On Tue, Jun 17, 2014 at 6:30 PM, Andrew Kaspick <akasp...@gmail.com> wrote: > Slight aside, but wouldn't a simple test case catch such an issue? > Whether that be an actual mailer test or reviewing a generated email? > On Jun 17, 2014 6:14 PM, "richard schneeman" <richard.schnee...@gmail.com> > wrote: > >> Are there any valid uses for *_path in an email? Can you do reference >> links with ID elements in an email? We could make it configurable. Default >> it to non-hair-pulling behavior, but allow anyone with a legitimate >> `*_path` use to preserve functionality. >> >> ``` >> config.action_mailer.path_helper_behavior = :raise >> config.action_mailer.path_helper_behavior = :url >> config.action_mailer.path_helper_behavior = :make_me_lose_users_or_money >> # i.e. current behavior >> ``` >> >> -- >> Richard Schneeman >> >> >> On Thu, Jun 12, 2014 at 2:31 PM, Xavier Noria <f...@hashref.com> wrote: >> >>> On Thu, Jun 12, 2014 at 8:07 PM, Florian Thomas <f...@florianthomas.net> >>> wrote: >>> >>> I’m in support of this as well. >>>> As a solution i would prefer to resolve the full URL by default. >>>> Raising an exception seems to me a bit like rails telling the programmer „I >>>> know what you’re intending, and we both know the solution but you have to >>>> fix it on your own." >>>> >>> >>> Breaking the strong expectation that *_path generates a path is dubious >>> to me. Too clever, the API is kind of cheating in my mind. >>> >>> I've been thinking about it and my only conclusion by now is that we >>> agree there's something to do here, but see cons in all proposals so far :). >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Ruby on Rails: Core" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to rubyonrails-core+unsubscr...@googlegroups.com. >>> To post to this group, send email to rubyonrails-core@googlegroups.com. >>> Visit this group at http://groups.google.com/group/rubyonrails-core. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-core+unsubscr...@googlegroups.com. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> Visit this group at http://groups.google.com/group/rubyonrails-core. >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscr...@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
