If we go down this route, the error message should be crystal clear: "The method `user_path` cannot be used in a mailer as relative links in emails do not work. Use `user_url` instead"
Also need to make sure that it raises when rendered with mail_view. On Wed, Jun 18, 2014 at 4:11 AM, Adam Piotrowski <adamsa...@gmail.com> wrote: > Nice idea in my opinion. > > > 2014-06-18 11:08 GMT+02:00 Prem Sichanugrist <sikand...@gmail.com>: > > I like that. Let's deprecate *_path in Mailer in 4.2 and remove in 5.0 >> >> -Prem >> >> On Jun 18, 2014, at 3:33 AM, Xavier Noria <f...@hashref.com> wrote: >> >> I cannot think of a valid use case for *_path in mailer views, so after >> thinking about it I personally would be inclined to remove them. >> >> People cannot upgrade and have their mailers crashing in production, so I >> think we have no option but to go through a deprecation cycle. >> >> If someone had a rare need to generate a path and the helpers were gone, >> they could still opt-in via *_url(only_path: true), which is something >> we could document in small font :). >> >> The mailer guide would need to reflect these changes. >> >> What do you think? >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-core+unsubscr...@googlegroups.com. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> Visit this group at http://groups.google.com/group/rubyonrails-core. >> For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-core+unsubscr...@googlegroups.com. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> Visit this group at http://groups.google.com/group/rubyonrails-core. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscr...@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
