On Mon, Dec 17, 2012 at 11:28 AM, Graydon Hoare <gray...@mozilla.com> wrote:

>
> Nice! The only things I'd ask are:
>
>   - I can't tell at a glance (sorry, RB-trees are always very subtle)
>     whether this is an LLRB. If not, could you make it so? It's likely
>     just a simplification to a couple of the functions.
>

I rewrote it to be left-leaning and was able to remove a bunch of code.
Thanks for the suggestion.

  - Would you mind, once all feedback is incorporated, if we pull this
>     into the stdlib? We have a bug open discussing cleanup and
>     (re)organization of the container types, fwiw, over here:
>
>     https://github.com/mozilla/rust/issues/3863
>
> Thanks for taking an interest in this.
>

I'd be thrilled for that. Plenty of feedback to accept first, though.
_______________________________________________
Rust-dev mailing list
Rust-dev@mozilla.org
https://mail.mozilla.org/listinfo/rust-dev

Reply via email to