On Tue, Sep 10, 2013 at 6:47 PM, Simon Sapin <[email protected]> wrote: > /// Call this to indicate the end of the input. > /// The Decoder instance should be discarded afterwards. > /// Some encodings may append some final output at this point. > /// May raise the decoding_error condition. > fn flush(output: &mut ~str) -> Option<DecodeError>;
Please call this "finish" instead of calling it "flush". In other APIs, for example JDK APIs, flush really just means flushing the current buffers instead of ending the stream, so calling the method that does end-of-stream processing "flush" would be confusing. -- Henri Sivonen [email protected] http://hsivonen.iki.fi/ _______________________________________________ Rust-dev mailing list [email protected] https://mail.mozilla.org/listinfo/rust-dev
