[
https://issues.apache.org/jira/browse/S4-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173520#comment-13173520
]
Karthik Kambatla commented on S4-33:
------------------------------------
To make s4.fixtures accessible to s4-comm as well, I split s4.fixtures across
s4-comm an s4-core. s4-core has the SocketAdapter and S4TestUtils. S4TestUtils
extends TestUtils to implement forkS4App() and forkS4Node().
When running tests from within Eclipse, this works absolutely fine. However,
gradle test fails because it doesn't understand symbols.
So, either s4-core should depend on s4-comm or the fixtures should move all the
way to s4-base. Which one do you think is better?
> s4-comm tests should use zookeeper
> ----------------------------------
>
> Key: S4-33
> URL: https://issues.apache.org/jira/browse/S4-33
> Project: Apache S4
> Issue Type: Sub-task
> Affects Versions: 0.5
> Reporter: Karthik Kambatla
> Fix For: 0.5
>
>
> [From Skype call on 12/20] s4-comm tests currently use file-based
> configurations - AssignmentFromFile, TopologyFromFile. Instead, they should
> change to using zookeeper-based configurations.
> Steps involved --
> 1. Move org.apache.s4.fixtures from s4-core/test to s4-comm/test to avoid
> duplication of code
> 2. Rewrite s4-comm/tests to use these fixtures.
> Issues --
> 1. s4.fixtures uses some App-related code
> Eager to hear comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
