[ 
https://issues.apache.org/jira/browse/S4-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated S4-33:
-------------------------------

    Attachment: S4-33.patch

The attached patch refactors s4.fixtures across s4-comm and s4-core.

The corresponding gradle scripts have been updated.

Note: the AppLoading test case fails and needs attention.
                
> TestUtils and modules should be split across s4-comm and s4-core
> ----------------------------------------------------------------
>
>                 Key: S4-33
>                 URL: https://issues.apache.org/jira/browse/S4-33
>             Project: Apache S4
>          Issue Type: Sub-task
>    Affects Versions: 0.5
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 0.5
>
>         Attachments: S4-33.patch
>
>
> [From Skype call on 12/20] s4-comm tests currently use file-based 
> configurations - AssignmentFromFile, TopologyFromFile. Instead, they should 
> change to using zookeeper-based configurations.
> Steps involved --
> 1. Move org.apache.s4.fixtures from s4-core/test to s4-comm/test to avoid 
> duplication of code
> 2. Rewrite s4-comm/tests to use these fixtures.
> Issues --
> 1. s4.fixtures uses some App-related code
> EDIT: This JIRA addresses only the Step 1 above. Step 2 should be a different 
> JIRA

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to