[ 
https://issues.apache.org/jira/browse/S4-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418182#comment-13418182
 ] 

Matthieu Morel commented on S4-82:
----------------------------------

Note that the proposed patch assumes that the partition never changes. In 
AssignmentFromZK, the partition is fetched upon Zookeeper connection 
initialization. If the connection is lost, we should actually fail-fast and 
kill the current node, so that no other partition is fetched. This is related 
to S4-85.
                
> Fix local communication optimization
> ------------------------------------
>
>                 Key: S4-82
>                 URL: https://issues.apache.org/jira/browse/S4-82
>             Project: Apache S4
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Matthieu Morel
>             Fix For: 0.5
>
>
> When a message is to be sent to the current partition, a simple optimization 
> is to bypass the communication layer. This is the purpose of the 
> "sendAndCheckIfLocal" method in the Sender class. Unfortunately, it seems the 
> localPartitionId variable is never set!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to