[
https://issues.apache.org/jira/browse/S4-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418371#comment-13418371
]
Daniel Gómez Ferro commented on S4-82:
--------------------------------------
The patch looks good, +1
I did a quick check and before the patch there were 0 local sends, after the
patch there are indeed many local sends that bypass the comm layer, good job!
I also agree that in case of a connection loss we should kill the node.
> Fix local communication optimization
> ------------------------------------
>
> Key: S4-82
> URL: https://issues.apache.org/jira/browse/S4-82
> Project: Apache S4
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Matthieu Morel
> Fix For: 0.5
>
>
> When a message is to be sent to the current partition, a simple optimization
> is to bypass the communication layer. This is the purpose of the
> "sendAndCheckIfLocal" method in the Sender class. Unfortunately, it seems the
> localPartitionId variable is never set!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
